Add variable not defined #1170
Merged
Add variable not defined #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variable `$src_post_id` is used here: - https://github.com/moderntribe/event-tickets/blob/910b6883a79935b56f09b4f90174ade582087c2f/src/Tribe/Admin/Move_Ticket_Types.php#L116 But is not defined nowhere inside of this method: https://github.com/moderntribe/event-tickets/blob/910b6883a79935b56f09b4f90174ade582087c2f/src/Tribe/Admin/Move_Ticket_Types.php#L85-L121
sc0ttkclark
added
needs ticket
sc0ttkclark
suggested changes
Mar 11, 2019
There was a problem hiding this comment.
@mitogh Is this in relation to a specific Green team ticket? Also this needs changelog (unless it was introduced in G19.04)
|
I'm not sure if there's a ticket for this but I faced while I was working on other ticket so I send a PR with the fix due the fact it was not that complex. I can update the changelog accordingly or close this PR if you think is better to keep it out of this release. Let me know what works best for you @sc0ttkclark Thanks. |
|
Changes has been applied as requested. Ticket: https://central.tri.be/issues/124164 cc @sc0ttkclark let me know if there's more feedback. |
sc0ttkclark
approved these changes
Mar 12, 2019
sc0ttkclark
added
merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://central.tri.be/issues/124164
Variable
$src_post_idis used here:But is not defined nowhere inside of this method: https://github.com/moderntribe/event-tickets/blob/910b6883a79935b56f09b4f90174ade582087c2f/src/Tribe/Admin/Move_Ticket_Types.php#L85-L121