Skip to content
This repository has been archived by the owner on Dec 22, 2020. It is now read-only.

Migrate Classic recurrence into Blocks #479

Merged
merged 1 commit into from Nov 7, 2018

Conversation

mitogh
Copy link
Contributor

@mitogh mitogh commented Nov 6, 2018

Fix missing variable

@mitogh mitogh added the status:code-review Issue or pull request is waiting for a Developer to take a second look label Nov 6, 2018
@bordoni bordoni added review:merge Code has been approved and is waiting to be merged and removed status:code-review Issue or pull request is waiting for a Developer to take a second look labels Nov 7, 2018
@bordoni
Copy link
Member

bordoni commented Nov 7, 2018

We should move this into master and merge it back into recurrence. Also changelog it

@bordoni bordoni added the review:changelog Developer needs to add a changelog to readme.md label Nov 7, 2018
@mitogh mitogh changed the base branch from task/recurrence to master November 7, 2018 01:03
@mitogh mitogh changed the base branch from master to task/recurrence November 7, 2018 01:03
@mitogh
Copy link
Contributor Author

mitogh commented Nov 7, 2018

Merging this one into recurrence first as we need to cherry pick to avoid getting the commits before this one from recurrence into master

@mitogh mitogh merged commit d43b8ba into task/recurrence Nov 7, 2018
@mitogh mitogh deleted the fix/missing-variable branch November 7, 2018 01:04
@bordoni
Copy link
Member

bordoni commented Nov 7, 2018

Sounds good.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
review:changelog Developer needs to add a changelog to readme.md review:merge Code has been approved and is waiting to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants