Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert into an inline return and remove non used variable #3100

Merged
merged 1 commit into from Mar 16, 2020
Merged

Convert into an inline return and remove non used variable #3100

merged 1 commit into from Mar 16, 2020

Conversation

mitogh
Copy link
Contributor

@mitogh mitogh commented Mar 14, 2020

Remove the need to declare a variable

@mitogh
Convert into an inline return and remove non used variable
717f6bb 
Remove the need to declare a variable
@mitogh mitogh self-assigned this Mar 14, 2020
@mitogh mitogh added the code review Status: requires a code review. label Mar 14, 2020
lucatume
lucatume approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@lucatume lucatume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the tests are passing (I've restarted them), change is ok, thanks.

@mitogh mitogh merged commit 25c9ff1 into release/B20.03 Mar 16, 2020
@mitogh
Copy link
Contributor Author

mitogh commented Mar 16, 2020

Thank you!

@mitogh mitogh deleted the spotfix/cleanup branch March 16, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucatume lucatume lucatume approved these changes

Assignees

@mitogh mitogh

Labels
code review Status: requires a code review.
Projects
None yet
Milestone
No milestone
2 participants
@mitogh @lucatume