When validating .min assets, check plugins_url().

[boonebgorges]

Previously: #495

Plugins like the-events-calendar load JS assets like this:

• Tribe__Assets::register() calls tribe_resource_url() generate an expected URL for the asset
• tribe_resource_url() builds an asset URL using plugins_url()
• This generated URL is then validated in Tribe__Assets::maybe_get_min_file(), which uses (among other things) WP_PLUGIN_URL

When WP_PLUGIN_URL and plugins_url() diverge, Tribe cannot find the assets, and they're not loaded. In my case, the divergence is because of the wordpress-mu-domain-mapping plugin (plugins_url() returns the mapped domain, while WP_PLUGIN_URL uses the primary URL of the installation), but it can happen whenever plugins_url is filtered.

This PR contains an ugly but simple workaround: Yet Another String Comparison, this one using plugins_url(). It's homely, but it works.

More generally, I wonder if maybe_get_min_file() is too aggressive in its validation. By simply returning false when it can't validate a file, it creates situations that are really hard to debug. It seems like it might be easier if the URLs were simply allowed to pass through, so that WP would enqueue the assets, which would then 404.

Alternatively, it may be useful to refactor maybe_get_min_file() so that, instead of simply bailing, any return value - false or a URL - is passed through a filter. This way, unorthodox setups could override the otherwise binding decisions of tribe-common :)

Thanks for considering!

[sc0ttkclark]

👍

[barryhughes]

🎫 #89228

[elimn]

Thanks for pursuing this @boonebgorges, we really appreciate the help in addressing some less common configurations.

Not long after your last PR, we discussed this method. In the long term we would like to replace it. The current one tries to reverse a URL to a filepath, but due to aliasing, filters, etc. this is all ultimately guesswork. Instead of having a method which accepts a URL and tries to reverse it, we want a method which accepts a path and outputs a URL. Then we can skip all of this convoluted business.

In the mean time, improving this method is most welcome. We would love to include your contribution here. Thank you very much!

[boonebgorges]

Thanks very much, @elimn! Feel free to ping me if you'd like feedback on potential solutions from someone who maintains non-standard setups.