Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adds static warning/notice gumps. #1741

Merged
merged 7 commits into from
Apr 27, 2024
Merged

fix: Adds static warning/notice gumps. #1741

merged 7 commits into from
Apr 27, 2024

Conversation

kamronbatman
Copy link
Contributor

@kamronbatman kamronbatman commented Apr 26, 2024 •
edited

Summary

  • Adds StaticNoticeGump<T> and StaticWarningGump<T>
  • Converts NoticeGump/WarningGump to use DynamicGump
  • Changes various uses of notice gump and warning gump to their static counterpart.

@kamronbatman kamronbatman changed the title fix: Adds static warning gump. fix: Adds static warning/notice gumps. Apr 26, 2024
@kamronbatman kamronbatman merged commit bb7bc57 into main Apr 27, 2024
12 of 13 checks passed
@kamronbatman kamronbatman deleted the kbatman/static_warning_gump branch April 27, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kamronbatman