feat: Cleans up UOP file handling. Adds automatic bounds.bin generation #1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kamronbatman
changed the title
kamronbatman
force-pushed
the
art-bounds
branch
from
516e6d8
to
2baacfe
Compare
kamronbatman
force-pushed
the
art-bounds
branch
from
2baacfe
to
eceb730
Compare
kamronbatman
changed the title
| return xMax switch | ||
| { | ||
| // If no non-black pixels were found, return an empty rectangle | ||
| -1 => Rectangle2D.Empty, |
There was a problem hiding this comment.
Note that in RunUO/ServUO, this value is [0, 0, 0xFFFF, 0xFFFF]. Intentionally different here. if the entire pic is black, there are no bounds, so we can keep it as all 00's. This also allows us to easily detect "empty" or "missing" entries without a validation structure.
| private void ConvertToMapEntries(FileStream stream) | ||
| { | ||
| // Sorting by offset to make seeking faster | ||
| Array.Sort(_uopMapEntries, (a, b) => a.Offset.CompareTo(b.Offset)); |
There was a problem hiding this comment.
This is only doable because I don't think the hashed file name order is important. I also don't think those files match the order field in the data block.
TODO: In the future we can memory map this and get good performance and wouldn't need the sort.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows for easy access to art dimensions and real bounds based on the pixel transparency.
Used for dynamically sized gumps and stuff.
Code is rough on the edges since it's almost untouched ServUO code, but System.Drawing.Imaging references are gone.
Tested and gives exactly the same results as original ServUO code.