fix: Removes broken OrderedHashSet and adds a simple OrderedSet #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamronbatman
changed the title
kamronbatman
commented
May 4, 2024
Comment on lines
+29
to
+30
| private readonly Dictionary<T, int> _dictionary; | ||
| private readonly List<T> _list; |
There was a problem hiding this comment.
I am so ashamed. I also don't care in this case since this is for legacy code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
BREAKING CHANGE
Removed
OrderdHashSetandPooledOrderedHashSetdue to bugs.Note
Developer Note
The OrderedSet is not a full data structure. It is not particularly efficient. Pull Requests are welcome for a better implementation, especially if it ends up supporting
ISet<T>andIReadOnlySet<T>Summary
The ordered hash set was buggy. It's kind of painful to implement, so for now, I added a simple
OrderedSetto suffice for gumps. Please reach out if this causes disruption!