Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url.shellescape breaks PhantomJS driver #271

Closed
nalbion opened this issue Oct 14, 2014 · 3 comments
Closed

url.shellescape breaks PhantomJS driver #271

nalbion opened this issue Oct 14, 2014 · 3 comments

Comments

@nalbion
Copy link

nalbion commented Oct 14, 2014

As per this StackOverflow post I'm getting the following error when I run teaspoon:

Teaspoon::UnknownSuite: Unknown suite "default\"

I've managed to track the problem down to lib/teaspoon/drivers/phantomjs_driver.rb in driver_options(url). For some reason (perhaps to URL-encode the suite name?) you call url.shellescape which changes the URL from

http://127.0.0.1:62848/teaspoon/default?reporter=Console

to

http://127.0.0.1:62848/teaspoon/default\?reporter\=Console

If I remove the call to .shellescape everything seems to behave.

@nalbion
Copy link
Author

nalbion commented Oct 14, 2014

It seems that this issue has been fixed in 0c5dd7f, but not yet released.

@jejacks0n
Copy link
Owner

yeah, I believe that was a PR for a windows fix, but it broke things elsewhere. I think we'll release teaspoon in the next month or so. Sorry about that.

@jejacks0n
Copy link
Owner

I believe I've resolved this.. I am not using shellescape anymore however, just wrap things in quotes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants