Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-species not working in SFT #27

Closed
emorway-usgs opened this issue Jan 8, 2018 · 1 comment
Closed

Multi-species not working in SFT #27

emorway-usgs opened this issue Jan 8, 2018 · 1 comment

Comments

@emorway-usgs
Copy link
Collaborator

SFT not properly accounting for multi-species. For example, compare the list files (*.m3d) from the two attached models, 1 and 2 species, respectively.

The following call in gnt1.f (line 39):

CALL xmdsolv(AMATSF, RHSSF, CNEWSF, hclosexmd, rrctol, IASF, 
&            JASF,NJASF,numactive, north, iter, iacl, ierr)

sends in numactive equal to the number of SFT cells. However, CNEWSF gets picked-up as x and numactive gets picked up as n. In xmdsolv.f, on line 1961, x is dimensioned as x(n), but this is a problem because CNEWSF is dimensioned as CNEWSF(1:650,1:2) when it gets sent in, and so the second species is not properly accounted for.

CrnkNic.zip

@emorway-usgs
Copy link
Collaborator Author

emorway-usgs commented Jan 10, 2018

@jtwhite79 This issue should be resolved with commit d916dd4

Tested with multi-species version of the 'CrnkNic' test problem. Please confirm all looks OK with your real-world model and reopen the issue if something is still amiss.

Screen shot showing budget for second species in SFT:

sft_multi_spec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant