Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with PyPi pymake? #86

Closed
markyoder opened this issue Mar 5, 2021 · 4 comments
Closed

Conflict with PyPi pymake? #86

markyoder opened this issue Mar 5, 2021 · 4 comments

Comments

@markyoder
Copy link

I am possibly confused. Does is this pymake specific to building modflow and modflow packages, or is it a version of the standard PyPi pymake? I am getting an error that is, in one form or another, most likely version related:

AttributeError: module 'pymake' has no attribute 'build_apps'

So I guess my question is, what is the relationship between modflowpy/pymake and PyPI/pymake (ie, pip install py-make )

Thanks!

@jdhughes-usgs
Copy link
Collaborator

There is no relationship between PyPI/pymake and modflowpy/pymake other than the name. modflowpy/pymake is not specific to MODFLOW but is primarily used by the authors to compile the various MODFLOW variants.

@markyoder
Copy link
Author

Ok, thanks. Would it make sense to call it something else, as to not step on the name pymake? Other than that, it works beautifully, but if PyPi.pymake is installed, the in-script applications will probably fail, and you generally run the risk of corrupting headers, etc. From what I can see, this is a simple matter of changing the name of they pymake directory and then (optionally) modifying the examples/ and of course the documentation. Thoughts?

@jdhughes-usgs
Copy link
Collaborator

Yes and the plan is to rename it (maybe mfmakepy) and make it available on PyPI. We haven't done it yet because we use it in most of our continuous integration workflows.

Any good suggestions for a new name?

@markyoder
Copy link
Author

markyoder commented Mar 5, 2021

Got it. I worked around the problem with a symlink, but I'm interested to integrate it into some other build scripts. If it's pretty general purpose, maybe py-compile ? other-pymake?
Thanks for the info. I'll keep an eye on the project -- happy to help out on a Fork as well.

... or, looking at some of the code (ie, pymake.usgs_program_data.export_json() ), something straightforward like pymake-usgs would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants