Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_date_index fails on certain modin versions #39

Closed
valerieyip opened this issue Apr 1, 2021 · 1 comment
Closed

test_date_index fails on certain modin versions #39

valerieyip opened this issue Apr 1, 2021 · 1 comment

Comments

@valerieyip
Copy link

Environment

  • Operating System: OSX
  • Python Version: $ python --version 3.8.5
  • How did you install modin-spreadsheet: (pip, conda, or other (please explain))
  • Python packages: $ pip freeze or $ conda list (please include modin-spreadsheet, notebook, and jupyterlab versions)
  • Jupyter lab packages (if applicable): $ jupyter labextension list

Description of Issue

test_date_index fails on certain modin issues:
0.8.1, 0.8.2, 0.9.1 works
0.8.3, 0.9.0 does not work

Reproduction Steps

pytest -k test_date_index

What steps have you taken to resolve this already?

Tried the modin versions above

Anything else?

problem appears to come from & operator between filtered panda dataframes with the same index for all rows. (combined_condition = combined_condition & c on line 1476 of grid.py) In versions that fail, the result of the & has excess rows (e.g. a 4 row dataframe becomes 16 rows)
...

@richardlin047
Copy link
Collaborator

According to @devin-petersohn , this occurs because of Pandas being inconsistent and the & operator on the series causes a cross-join. Fixed in 0.9.1 release of Modin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants