Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numerical functions that can only use numeric inputs (var, skew, mean but not max, min) #132

Closed
williamma12 opened this issue Oct 8, 2018 · 0 comments · Fixed by #133
Assignees
Labels
bug 🦗 Something isn't working

Comments

@williamma12
Copy link
Collaborator

Describe the problem

Uses only numeric values even when numeric_only=False. We should be consistent with pandas and throw TypeErrors

Source code / logs

import modin.pandas as pd
data = {
        "col1": 1.0,
        "col2": np.datetime64("2011-06-15T00:00"),
        "col3": np.array([3] * 4, dtype="int32"),
        "col4": "foo",
        "col5": True,
}
modin_df = pd.DataFrame(data)
modin_df.median(axis='rows', skipna = False, numeric_only = False)

Should throw a TypeError but returns

col1    1.0
col3    3.0
col5    1.0
dtype: float64

as if numeric_only=True

@williamma12 williamma12 added the bug 🦗 Something isn't working label Oct 8, 2018
@williamma12 williamma12 self-assigned this Oct 8, 2018
@williamma12 williamma12 mentioned this issue Oct 8, 2018
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🦗 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant