Squeeze functionality #141

adits31 · 2018-10-09T11:18:38Z

What do these changes do?

Adding squeeze() functionality for modin. Basic test with several cases also included in test_dataframe.py. Currently returns pandas.Series where necessary because no Series implementation in modin yet.

passes git diff upstream/master -u -- "*.py" | flake8 --diff
passes black --check modin/

AmplabJenkins · 2018-10-18T21:30:56Z

Merged build finished. Test FAILed.

AmplabJenkins · 2018-10-18T21:30:57Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin/302/
Test FAILed.

devin-petersohn

Left a few comments. Thanks!

modin/data_management/data_manager.py

modin/pandas/dataframe.py

modin/data_management/data_manager.py

AmplabJenkins · 2018-10-25T20:42:54Z

Build finished. Test FAILed.

AmplabJenkins · 2018-10-25T20:42:55Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin/414/
Test FAILed.

AmplabJenkins · 2018-10-25T20:46:29Z

Build finished. Test FAILed.

AmplabJenkins · 2018-10-25T20:46:30Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin/415/
Test FAILed.

AmplabJenkins · 2018-10-26T21:27:25Z

Merged build finished. Test PASSed.

AmplabJenkins · 2018-10-26T21:27:26Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/4/
Test PASSed.

AmplabJenkins · 2018-10-26T21:36:14Z

Merged build finished. Test PASSed.

AmplabJenkins · 2018-10-26T21:36:15Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/5/
Test PASSed.

AmplabJenkins · 2018-10-26T22:49:22Z

Merged build finished. Test PASSed.

AmplabJenkins · 2018-10-26T22:49:22Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-Performance-Testing/1/
Test PASSed.

AmplabJenkins · 2018-11-05T02:38:10Z

Merged build finished. Test PASSed.

AmplabJenkins · 2018-11-05T02:38:11Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-Performance-Testing/32/
Test PASSed.

AmplabJenkins · 2018-11-05T02:40:09Z

Merged build finished. Test PASSed.

AmplabJenkins · 2018-11-05T02:40:10Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/43/
Test PASSed.

AmplabJenkins · 2018-11-09T23:14:10Z

Merged build finished. Test PASSed.

AmplabJenkins · 2018-11-09T23:14:11Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-Performance-Testing/46/
Test PASSed.

AmplabJenkins · 2018-11-09T23:15:50Z

Merged build finished. Test PASSed.

AmplabJenkins · 2018-11-09T23:39:44Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-Performance-Testing/49/
Test PASSed.

AmplabJenkins · 2018-11-09T23:41:02Z

Merged build finished. Test PASSed.

AmplabJenkins · 2018-11-09T23:41:03Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/60/
Test PASSed.

AmplabJenkins · 2018-11-09T23:42:54Z

Merged build finished. Test PASSed.

AmplabJenkins · 2018-11-09T23:42:55Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-Performance-Testing/50/
Test PASSed.

AmplabJenkins · 2018-11-09T23:44:29Z

Merged build finished. Test PASSed.

AmplabJenkins · 2018-11-09T23:44:29Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/61/
Test PASSed.

osalpekar

Left some comments!

modin/pandas/test/test_dataframe.py

modin/pandas/dataframe.py

modin/data_management/query_compiler/pandas_query_compiler.py

AmplabJenkins · 2018-11-10T01:24:53Z

Merged build finished. Test PASSed.

AmplabJenkins · 2018-11-10T01:24:54Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-Performance-PRB/5/
Test PASSed.

AmplabJenkins · 2018-11-10T01:27:34Z

Merged build finished. Test PASSed.

AmplabJenkins · 2018-11-10T01:27:35Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/68/
Test PASSed.

AmplabJenkins · 2018-11-10T01:46:27Z

Merged build finished. Test PASSed.

AmplabJenkins · 2018-11-10T01:46:27Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-Performance-PRB/6/
Test PASSed.

AmplabJenkins · 2018-11-10T01:49:16Z

Merged build finished. Test PASSed.

AmplabJenkins · 2018-11-10T01:49:17Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/69/
Test PASSed.

williamma12

Looks good! Just one minor change

williamma12

the minor change i was referring to

modin/pandas/dataframe.py

Co-Authored-By: adits31 <adityasheth@berkeley.edu>

AmplabJenkins · 2018-11-16T00:59:59Z

Merged build finished. Test PASSed.

AmplabJenkins · 2018-11-16T01:00:00Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-Performance-PRB/36/
Test PASSed.

AmplabJenkins · 2018-11-16T01:00:34Z

Merged build finished. Test PASSed.

AmplabJenkins · 2018-11-16T01:00:35Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/99/
Test PASSed.

adits31 force-pushed the squeeze branch from c526d64 to 16bcc2e Compare October 18, 2018 21:29

devin-petersohn reviewed Oct 20, 2018

View reviewed changes

modin/data_management/data_manager.py Outdated Show resolved Hide resolved

modin/pandas/dataframe.py Outdated Show resolved Hide resolved

modin/data_management/data_manager.py Outdated Show resolved Hide resolved

adits31 force-pushed the squeeze branch from 16bcc2e to 43833f1 Compare October 25, 2018 20:42

adits31 force-pushed the squeeze branch from 24d3e62 to ea0fbb5 Compare October 26, 2018 21:21

adits31 force-pushed the squeeze branch from 7221c05 to b6a8675 Compare November 5, 2018 02:35

adits31 added 5 commits November 9, 2018 15:10

squeeze fixes

313b626

updated squeeze

9b50030

fixed rebasing issue

5c271dc

updated squeeze

f13837d

updating to fix travis fails

8dda1cc

adits31 force-pushed the squeeze branch from b6a8675 to 8dda1cc Compare November 9, 2018 23:10

removed unncess comments

71e3cd3

osalpekar reviewed Nov 10, 2018

View reviewed changes

adits31 added 2 commits November 9, 2018 16:33

Merge branch 'squeeze' of https://github.com/adits31/modin into squeeze

d7296ea

addressing comments

ecbb566

fixed formatting

5dfb4dd

williamma12 requested changes Nov 16, 2018

View reviewed changes

williamma12 reviewed Nov 16, 2018

View reviewed changes

modin/pandas/dataframe.py Outdated Show resolved Hide resolved

changed an ndim parameter

ab43270

Co-Authored-By: adits31 <adityasheth@berkeley.edu>

williamma12 approved these changes Nov 16, 2018

View reviewed changes

williamma12 merged commit 16c0f6b into modin-project:master Nov 16, 2018

Squeeze functionality #141

Squeeze functionality #141

Conversation

adits31 commented Oct 9, 2018 • edited by williamma12

What do these changes do?

AmplabJenkins commented Oct 18, 2018

AmplabJenkins commented Oct 18, 2018

devin-petersohn left a comment

Choose a reason for hiding this comment

AmplabJenkins commented Oct 25, 2018

AmplabJenkins commented Oct 25, 2018

AmplabJenkins commented Oct 25, 2018

AmplabJenkins commented Oct 25, 2018

AmplabJenkins commented Oct 26, 2018

AmplabJenkins commented Oct 26, 2018

AmplabJenkins commented Oct 26, 2018

AmplabJenkins commented Oct 26, 2018

AmplabJenkins commented Oct 26, 2018

AmplabJenkins commented Oct 26, 2018

AmplabJenkins commented Nov 5, 2018

AmplabJenkins commented Nov 5, 2018

AmplabJenkins commented Nov 5, 2018

AmplabJenkins commented Nov 5, 2018

AmplabJenkins commented Nov 9, 2018

AmplabJenkins commented Nov 9, 2018

AmplabJenkins commented Nov 9, 2018

AmplabJenkins commented Nov 9, 2018

AmplabJenkins commented Nov 9, 2018

AmplabJenkins commented Nov 9, 2018

AmplabJenkins commented Nov 9, 2018

AmplabJenkins commented Nov 9, 2018

AmplabJenkins commented Nov 9, 2018

AmplabJenkins commented Nov 9, 2018

osalpekar left a comment

Choose a reason for hiding this comment

AmplabJenkins commented Nov 10, 2018

AmplabJenkins commented Nov 10, 2018

AmplabJenkins commented Nov 10, 2018

AmplabJenkins commented Nov 10, 2018

AmplabJenkins commented Nov 10, 2018

AmplabJenkins commented Nov 10, 2018

AmplabJenkins commented Nov 10, 2018

AmplabJenkins commented Nov 10, 2018

williamma12 left a comment

Choose a reason for hiding this comment

williamma12 left a comment

Choose a reason for hiding this comment

AmplabJenkins commented Nov 16, 2018

AmplabJenkins commented Nov 16, 2018

AmplabJenkins commented Nov 16, 2018

AmplabJenkins commented Nov 16, 2018

adits31 commented Oct 9, 2018 •

edited by williamma12