Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dataframe hierarchy with better names #3998

Open
RehanSD opened this issue Jan 18, 2022 · 1 comment
Open

Refactor dataframe hierarchy with better names #3998

RehanSD opened this issue Jan 18, 2022 · 1 comment
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase P3 Very minor bugs, or features we can hopefully add some day.

Comments

@RehanSD
Copy link
Collaborator

RehanSD commented Jan 18, 2022

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. What kind of performance improvements would you like to see with this new API?
We want to refactor the Dataframe hierarchy with better names, to include the ModinDataframe.

@RehanSD
Copy link
Collaborator Author

RehanSD commented Jan 18, 2022

This issue is motivated by this comment on the refactor pr #3717 that introduced the ModinDataframe and df algebra to the codebase.

The (paraphrased) resolution:

We could keep the name for ModinDataframe, since it just exposes the algebra, and then rename the PandasDataframe the PartitionedModinDataframe since it implements the algebra but also knows that its partitioned.

This will also require us to separate out the pandas logic from the PandasDataframe into a mixin.

@anmyachev anmyachev added the Code Quality 💯 Improvements or issues to improve quality of codebase label Apr 21, 2022
@vnlitvinov vnlitvinov added the P3 Very minor bugs, or features we can hopefully add some day. label Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase P3 Very minor bugs, or features we can hopefully add some day.
Projects
None yet
Development

No branches or pull requests

3 participants