Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On empty dataframes, methods (that go through __getattribute__) default to pandas #4418

Open
anmyachev opened this issue Apr 25, 2022 · 1 comment
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase Internals Internal modin functionality P2 Minor bugs or low-priority feature requests

Comments

@anmyachev
Copy link
Collaborator

However, magic methods do not pass through function __getattribute__ (for example: __setitem__). Should we do a similar check for them?

Also, for some functions, code branches remained for cases where one of several axes has zero length (for example: insert). In the current implementation, these code paths are unreachable for the thread of execution. I think that they need to be removed. @modin-project/modin-core what do you think about this?

Links:

@anmyachev anmyachev added Code Quality 💯 Improvements or issues to improve quality of codebase Internals Internal modin functionality labels Apr 25, 2022
@vnlitvinov vnlitvinov added the P2 Minor bugs or low-priority feature requests label Sep 6, 2022
@vnlitvinov
Copy link
Collaborator

I guess this should be a subset of #4605 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase Internals Internal modin functionality P2 Minor bugs or low-priority feature requests
Projects
None yet
Development

No branches or pull requests

2 participants