Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: Refactor full_axis argument #4757

Open
RehanSD opened this issue Aug 2, 2022 · 1 comment
Open

REFACTOR: Refactor full_axis argument #4757

RehanSD opened this issue Aug 2, 2022 · 1 comment
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase P3 Very minor bugs, or features we can hopefully add some day.

Comments

@RehanSD
Copy link
Collaborator

RehanSD commented Aug 2, 2022

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. What kind of performance improvements would you like to see with this new API?
full_axis at the virtual partition level is used as a flag to tell the partition whether to block partition after or to materialize the result as a single partition - we should probably change it from full_axis to a more descriptive name that better reflects its usage.

@mvashishtha mvashishtha changed the title Refactor full_axis argument REFACTOR: Refactor full_axis argument Aug 2, 2022
@mvashishtha mvashishtha added the Code Quality 💯 Improvements or issues to improve quality of codebase label Aug 2, 2022
@mvashishtha
Copy link
Collaborator

mvashishtha commented Aug 2, 2022

I think we can also stop making it a property of the axis object, and instead control the full_axis behavior with arguments to apply. apply seems to be the only thing that uses the full_axis argument.

edit: Or perhaps even better, always make apply return a single partition, and split the result with another method.

@pyrito pyrito added the P3 Very minor bugs, or features we can hopefully add some day. label Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase P3 Very minor bugs, or features we can hopefully add some day.
Projects
None yet
Development

No branches or pull requests

3 participants