Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define a proper behavior for deserialize to materialize a dict object #5274

Open
YarShev opened this issue Nov 28, 2022 · 1 comment
Open

Define a proper behavior for deserialize to materialize a dict object #5274

YarShev opened this issue Nov 28, 2022 · 1 comment
Labels
bug 🦗 Something isn't working P2 Minor bugs or low-priority feature requests Ray ⚡ Issues related to the Ray engine

Comments

@YarShev
Copy link
Collaborator

YarShev commented Nov 28, 2022

Originally found in #5059 (comment).

We should probably perform a partial materialization the same way as we do for lists and tuples in the function.
@YarShev YarShev added the bug 🦗 Something isn't working label Nov 28, 2022
@YarShev YarShev mentioned this issue Nov 28, 2022
Merged
7 tasks
@mvashishtha mvashishtha added the unidist Related to unidist backend label Nov 29, 2022
@mvashishtha mvashishtha changed the title Define a proper behavior for deserialize to materialize a dict object Unidist: Define a proper behavior for deserialize to materialize a dict object Nov 29, 2022
@mvashishtha mvashishtha added the P2 Minor bugs or low-priority feature requests label Nov 29, 2022
@YarShev
Copy link
Collaborator Author

YarShev commented Nov 30, 2022

Already fixed for unidist, should be fixed for ray.

modin/modin/core/execution/unidist/common/utils.py

Line 89 in 193505f

return dict(zip(obj.keys(), deserialize(tuple(obj.values()))))

@YarShev YarShev changed the title Unidist: Define a proper behavior for deserialize to materialize a dict object Define a proper behavior for deserialize to materialize a dict object Nov 30, 2022
@YarShev YarShev added Ray ⚡ Issues related to the Ray engine and removed unidist Related to unidist backend labels Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🦗 Something isn't working P2 Minor bugs or low-priority feature requests Ray ⚡ Issues related to the Ray engine
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mvashishtha @YarShev