FIX-#3080: Fix case when there is duplicated columns for read_csv on hdk #5519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… read_csv on hdk Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
ienkovich
reviewed
Jan 4, 2023
| @@ -299,6 +299,9 @@ def read_csv( | |||
| parse_options=po, | |||
| convert_options=co, | |||
| ) | |||
| if len(set(at.schema.names)) < len(at.schema.names): | |||
There was a problem hiding this comment.
IIUC defaulting to pandas here means we read a CSV file using the original Pandas API, then convert it to Arrow table, and pass this table to the same from_arrow used below. So, we pay full file read + conversion price just to use Pandas column mangling functionality.
We can obtain mangled names by running the original Pandas read_csv with nrows=0 and assign them to Arrow table using pyarrow.Table.rename_columns. We can also mangle names by ourselves because mangling is documented. If mangling is disabled then duplicated columns are simply dropped.
There was a problem hiding this comment.
Implemented column names mangling - #5639 .
|
Closed in favour of #5639 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anatoly Myachev anatoly.myachev@intel.com
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sread_csvwith OmniSci backend doesn't handle duplicated columns #3080docs/development/architecture.rstis up-to-date