Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop monkey patching MultiIndex.from_frame to allow from_frame(modin_frame) #7121

Open
mvashishtha opened this issue Mar 25, 2024 · 1 comment
Labels
bug 🦗 Something isn't working P3 Very minor bugs, or features we can hopefully add some day.

Comments

@mvashishtha
Copy link
Collaborator

Background: #2575

here, we monkey patch pandas.MultiIndex.from_frame to allow from_frame(modin_frame). That's not consistent with how we support interoperability between Modin and pandas in general. Users should do from_frame(modin_frame._to_pandas()). Also we want to avoid monkey patching in general, and this monkey patch causes from_frame to recurse ad infinitum when we reload pd.utils here.

Eventually we hope to add our own modin.pandas.Index, which could implement methods like from_frame(modin_frame).

@mvashishtha mvashishtha added P3 Very minor bugs, or features we can hopefully add some day. Enable plugin Fixes needed to enable external plugins labels Mar 25, 2024
@mvashishtha
Copy link
Collaborator Author

When we fix #7138, we will stop reloading pd.utils, so we don't need this fix to enable plugins.

@mvashishtha mvashishtha added bug 🦗 Something isn't working and removed Enable plugin Fixes needed to enable external plugins labels Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🦗 Something isn't working P3 Very minor bugs, or features we can hopefully add some day.
Projects
None yet
Development

No branches or pull requests

1 participant