Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT-#54 Add unidist main logo image #108

Merged
merged 5 commits into from Jan 31, 2022
Merged

FEAT-#54 Add unidist main logo image #108

merged 5 commits into from Jan 31, 2022

Conversation

no-ponomarev
Copy link
Collaborator

@no-ponomarev no-ponomarev commented Jan 28, 2022 •
edited by YarShev

What do these changes do?

Add logo to the README

  • passes flake8 .
  • passes black .
  • signed commit with git commit -s
  • Resolves Logo design #54
  • tests added and passing
  • module layout described at docs/developer/architecture.rst is up-to-date

@no-ponomarev no-ponomarev added the documentation 📜 Improvements or additions to documentation label Jan 28, 2022
@no-ponomarev no-ponomarev added this to the 0.1.0 milestone Jan 28, 2022
@prutskov
Copy link
Contributor

Additionally, logo should be added to main page of rst docs. Do we have only .png? .svg format would be more flexible.

@YarShev
Copy link
Collaborator

YarShev commented Jan 28, 2022

@no-ponomarev, please fix commit message.

YarShev
YarShev reviewed Jan 28, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@YarShev
Copy link
Collaborator

YarShev commented Jan 28, 2022

I do not think we are going to change the logo so png is enough.

@prutskov
Copy link
Contributor

I do not think we are going to change the logo so png is enough.

The reason by what I propose to use .svg is not future changes of the logo design. png format has fixed resolution, but svg adapts to every resolutions.

@no-ponomarev
Copy link
Collaborator Author

I do not think we are going to change the logo so png is enough.

The reason by what I propose to use .svg is not future changes of the logo design. png format has fixed resolution, but svg adapts to every resolutions.

Figma can export to svg also. As I see, modin logo is stored in png too. It is a default transparent format for images.

@no-ponomarev no-ponomarev changed the title Logo design FEAT-#103 Add unidist main logo image Jan 28, 2022
@no-ponomarev no-ponomarev changed the title FEAT-#103 Add unidist main logo image FEAT-#54 Add unidist main logo image Jan 28, 2022
@no-ponomarev
FEAT-modin-project#54: Add unidist main logo image
52a83db 
Signed-off-by: Nikita Ponomarev <nikita.ponomarev@intel.com>
@no-ponomarev
Copy link
Collaborator Author

no-ponomarev commented Jan 28, 2022 •
edited

Additionally, logo should be added to main page of rst docs. Do we have only .png? .svg format would be more flexible.

Added on the index.rst page

YarShev
YarShev approved these changes Jan 31, 2022
View reviewed changes
Copy link
Collaborator

@YarShev YarShev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! LGTM!

@prutskov prutskov merged commit 0072937 into modin-project:master Jan 31, 2022
@no-ponomarev no-ponomarev deleted the dev/logo-design branch February 1, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prutskov prutskov prutskov approved these changes

@YarShev YarShev YarShev approved these changes

Assignees
No one assigned
Labels
documentation 📜 Improvements or additions to documentation
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

Logo design
3 participants
@no-ponomarev @prutskov @YarShev