Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar Problem - double quotes #37

Closed
twalmsley opened this issue Jun 22, 2019 · 4 comments
Closed

Grammar Problem - double quotes #37

twalmsley opened this issue Jun 22, 2019 · 4 comments
Assignees

Comments

@twalmsley
Copy link
Collaborator

twalmsley commented Jun 22, 2019

this fails to parse:

a="x".p;

but its fine if the .p is removed, or if we use graves instead of double quotes, or if both double quotes are escaped.

Is this a problem that needs to be fixed or can we live with it?

@twalmsley twalmsley self-assigned this Jun 22, 2019
@twalmsley
Copy link
Collaborator Author

This can probably be ignored since it can be written as:

a="x.p";

I've looked into making graves and quotes behave the same way before and failed to get a working grammar - I expect it would mean a major restructure and we should just accept that graves will never be the same as quotes.

@elliottinvent
Copy link
Member

I've got a new version of the grammar that deals with a="x".p; ok and hasn't had any trouble with a bunch of random tests I've given it. Have added as branch elliott-grammar-changes.

@twalmsley
Copy link
Collaborator Author

This doesn't parse with the new grammar, but if that is now correct behaviour the ticket can be closed.

@elliottinvent
Copy link
Member

Yes this should fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants