Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] disable command doesnt disable react to contact #2969

Closed
fourjr opened this issue Mar 10, 2021 · 5 comments
Closed

[BUG] disable command doesnt disable react to contact #2969

fourjr opened this issue Mar 10, 2021 · 5 comments
Labels
feature request staged Staged for next version

Comments

@fourjr
Copy link
Collaborator

fourjr commented Mar 10, 2021

Describe the bug
Using the disable command does not affect react to contact threads

Bot Info
Bot version (check with @modmail about): v3.8.5
Host method (Heroku, self-host, etc): selfhost (doesnt matter)

To Reproduce
Steps to reproduce the behavior:

  1. Who can reproduce (ex. anyone, owners)?
  2. Where can it be reproduced (ex. in thread channels, recipient DM's)?
  3. Done what to cause the error?
  4. Any recently made changes to your bot?
  5. Errored
  • run ?disable new
  • try creating thread by dming bot (works correctly)
  • try using react to contact (works but shld be disabled)

Error Logs
If your Modmail bot is online, type @modmail debug hastebin and include the link here.
If your Modmail bot is not online or the previous command did not generate a link, do the following:

  1. Select your bot application at https://dashboard.heroku.com
  2. Restart your bot
  3. Reproduce the error to populate the error logs
  4. Copy and paste the logs

Screenshots
Add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

Possible solution could be additional granularity to the disable command to prevent breaking current functionality

@fourjr fourjr added maybe: bug An unconfirmed bug bug This is a confirmed bug feature request and removed maybe: bug An unconfirmed bug labels Mar 10, 2021
@fourjr
Copy link
Collaborator Author

fourjr commented Mar 19, 2021

The initial bug part of this has been resolved. However, the issue will remain open as a feature request for additional granularity to the ?disable command.

@fourjr fourjr removed the bug This is a confirmed bug label Mar 19, 2021
@coleslaw12
Copy link

Im unsure if this falls in the same category, but the ?block command doesnt disable react_to_contact either.

@martinbndr
Copy link
Contributor

Yes for me too. Users still can open tickets through the reaction even they are blocked. @fourjr Maybe you need to look at this and fix it.

@Jerrie-Aries
Copy link
Contributor

Im unsure if this falls in the same category, but the ?block command doesnt disable react_to_contact either.

Yes for me too. Users still can open tickets through the reaction even they are blocked. fourjr Maybe you need to look at this and fix it.

I'm going to try and look into these.

@fourjr
Copy link
Collaborator Author

fourjr commented Aug 7, 2021

Issue resolved

@fourjr fourjr closed this as completed Aug 7, 2021
@fourjr fourjr added the staged Staged for next version label Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request staged Staged for next version
Projects
None yet
Development

No branches or pull requests

4 participants