Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modx:install command fails #431

Closed
hugopeek opened this issue Mar 23, 2023 · 3 comments
Closed

modx:install command fails #431

hugopeek opened this issue Mar 23, 2023 · 3 comments

Comments

@hugopeek
Copy link
Contributor

Summary

Hi all. Thanks for releasing 2.0.0-pl. Nice work! There is one problem though: the install command is broken, because it also has a --config option..

Step to reproduce

Install 2.0.0-pl and run gitify modx:install

Observed behavior

Error returned: An option named "config" already exists.

Expected behavior

The base config option should not interfere with the modx:install flag. Should we rename one of them? Or can we avoid collition some other way?

Environment

Gitify 2.0.0-pl
MODX 2.8.5
PHP 8.1

Related

Base config option was introduced in #417

@muzzwood
Copy link
Contributor

Holy moly, that one went right past me. 🤦🏻 Thanks for spotting that so quickly @hugopeek !
I'll get it sorted today.

@muzzwood
Copy link
Contributor

Hi @hugopeek , 2.0.1 is out now with the new base config option renamed to --dotfile.

@hugopeek
Copy link
Contributor Author

Hi @muzzwood, thank you for the quick reaction! Yeah, just sheer coincidence that I was setting up a new project exactly on the day of release. That process is automated and installs Gitify per project, so I noticed soon enough :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants