Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for haveFailed() matcher are incomplete #3

Open
modocache opened this issue Feb 18, 2015 · 3 comments
Open

Unit tests for haveFailed() matcher are incomplete #3

modocache opened this issue Feb 18, 2015 · 3 comments

Comments

@modocache
Copy link
Owner

Tests should be added for the cases in which the result is a failure, but doesn't match the specified domain or description.

@m3ta4a
Copy link

m3ta4a commented Dec 9, 2017

I've submitted a PR that breaks a couple haveFailed() specs (but updates to latest Nimble), once I figure out how to fix them I'll try to add the requested tests. Help would be appreciated though, I'm lacking context and intent. @modocache

@m3ta4a
Copy link

m3ta4a commented Dec 12, 2017

It looks like version 7.0.0 of Nimble introduced a change which evaluates the expressions in a try clause for the purpose of clarifying failure messages (line 48 in Nimble's Expectation.swift). This breaks the haveFailed() specs which intentionally throw errors, since Nimble catches them. It might be prudent to add new matchers which expect errors to be thrown, as opposed to expecting a failure?

@m3ta4a
Copy link

m3ta4a commented Dec 12, 2017

🦗🦗🦗🦗🦗🦗🦗 ... anyone here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants