Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting notifications from the future (wording?) #1658

Open
joernott opened this issue Mar 13, 2024 · 0 comments
Open

Getting notifications from the future (wording?) #1658

joernott opened this issue Mar 13, 2024 · 0 comments
Labels
bug For issues where things aren't working as intended

Comments

@joernott
Copy link

Describe the bug

I am getting notifications from the future:
modrinth_notifications-from-the-future
This looks like a wording issue or a timezone issue, it is correct for "a month ago" but "Recieved in 14 hours" should be either "Will receive in 14 hours" or "received 14 hours ago".

Steps to reproduce

  1. Ensure, your timezone is Europe/Berlin (CET or Z+0100)
  2. Follow a project (ideally one from a vastly different time zone)
  3. Look at the notifications page less than a day after the project received an update

Expected behavior

The notification should read "Received x hours ago"

Additional context

I have encountered similar issues in projects where timestamps used local time instead of UTC and saved them without the timezone. When someone from timezone A uploaded something and someone from a different timezone looked at the timestamp, the timezone was not accounted for and it looked like the upload happened in the future or hours ago.

@joernott joernott added the bug For issues where things aren't working as intended label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For issues where things aren't working as intended
Development

No branches or pull requests

1 participant