Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use singular "download" instead of plural if only 1 download #682

Closed
James103 opened this issue Oct 2, 2022 · 2 comments · Fixed by #1053
Closed

Use singular "download" instead of plural if only 1 download #682

James103 opened this issue Oct 2, 2022 · 2 comments · Fixed by #1053
Assignees
@ZachBaird
Labels
bug For issues where things aren't working as intended

Comments

@James103
Copy link

James103 commented Oct 2, 2022

Environment

Website

Describe the bug

If a download counter is currently at 1, it should say "1 download" instead of "1 downloads".

Steps To Reproduce

Navigate to https://modrinth.com/modpack/adrenaline/versions and scroll down to see the error.

Expected behavior

The download counters that currently say "1 downloads" should say "1 download".

Additional context

No response
@James103 James103 added the bug For issues where things aren't working as intended label Oct 2, 2022
@triphora triphora linked a pull request Oct 2, 2022 that will close this issue
Add internationalization support #670
Closed
@triphora triphora linked a pull request Nov 17, 2022 that will close this issue
Add internationalization support #738
Merged
@triphora triphora removed a link to a pull request Jan 12, 2023
Add internationalization support #738
Merged
@ZachBaird
Copy link
Contributor

This doesn't seem to be an issue anymore.

@James103 Can you confirm this as well?

@James103
Copy link
Author

James103 commented Mar 17, 2023 •
edited
Loading

Confirmed to be fixed on my end. Closing.

EDIT: Actually, it says "1 download" on the card in the description page, but "1 downloads" on the version page. Reopening until that is fixed.
image

@James103 James103 reopened this Mar 17, 2023
@ZachBaird ZachBaird self-assigned this Mar 17, 2023
@ZachBaird ZachBaird mentioned this issue Mar 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZachBaird ZachBaird

Labels
bug For issues where things aren't working as intended
Milestone
No milestone
2 participants
@ZachBaird @James103