Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some project settings buttons don't have a focus outline #944

Open
MMK21Hub opened this issue Jan 23, 2023 · 2 comments
Open

Some project settings buttons don't have a focus outline #944

MMK21Hub opened this issue Jan 23, 2023 · 2 comments
Labels
bug For issues where things aren't working as intended

Comments

@MMK21Hub
Copy link
Contributor

MMK21Hub commented Jan 23, 2023

Describe the bug

When using Firefox, a few of the buttons on the project settings page don't have Modrinth's custom purple or green outline when focused, and use the default browser focus style instead. This is most apparent on the "Save changes" button at the bottom of the page.

This behaviour is inconsistent with other buttons on the page and elsewhere on the site. It is also an accessibility issue, as the default focus outline can be difficult to see.

Here are the buttons that are affected by this bug:

Steps to reproduce

Please use Firefox to reproduce this issue.

  1. Go to the settings of a project
  2. Make a change to one of the settings (to enable the "Save changes" button)
  3. Press the Tab key until the "Save changes" button is focused

Expected behavior

The focus style would match the style seen on (for example) the "Remove icon" button in the General tab.

Notes

This issue is reproducible in Firefox, but not Brave browser. I have not tested any others.

@triphora triphora added the bug For issues where things aren't working as intended label May 14, 2023
@w26ad
Copy link

w26ad commented Feb 1, 2024

Can't reproduce, 'Save changes' and 'Delete project' have a purple outline now

@MMK21Hub
Copy link
Contributor Author

Upon further testing, it seems like this bug is only reproducible in Firefox. I have updated the issue description to reflect this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For issues where things aren't working as intended
Development

No branches or pull requests

3 participants