Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DG method #22

Closed
schmoelder opened this issue Mar 10, 2020 · 2 comments
Closed

Implement DG method #22

schmoelder opened this issue Mar 10, 2020 · 2 comments

Comments

@schmoelder
Copy link
Contributor

Works by Kristian Meyer have shown speed improvements in the order of 10^2 using Discontinuous Galerkin method (standard nodal DG-method). This could be implemented for CADET.

@sleweke
Copy link
Member

sleweke commented Mar 20, 2020

This would actually simplify a lot of the GRM, LRMP, and GRM2D code, because we can remove the domain decomposition inside the unit operation. We just dump the Jacobian into a large / big-ish sparse matrix and use a direct solver. We then revert to the adaptive Jacobian update strategy of IDAS.

Careful planning could also simplify implementation of the unit operations:

  • Each operator can be abstracted into a function or class
  • Models are simply composed by inserting the operators:
    dc_dt = -u * convection(c) + D_ax * dispersion(c) - ...
    
  • This is basically an embedded DSL in the C++ code
  • Use expression templates to generate fast element assembly code

Implementing DG shouldn't be that hard, I think.

@jbreue16
Copy link
Contributor

jbreue16 commented May 2, 2024

DG method added in #110

@jbreue16 jbreue16 closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants