Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename parameters to comply with new nomenclature #30

Open
schmoelder opened this issue Mar 10, 2020 · 3 comments
Open

Rename parameters to comply with new nomenclature #30

schmoelder opened this issue Mar 10, 2020 · 3 comments
Labels
good first issue Good starting point for newcomers, easy to fix

Comments

@schmoelder
Copy link
Contributor

In all of CADET documentation, the following nomenclature is used:
cf: fluid phase concentration
cp: pore concentration
cs: solid phase concentration

In the code, however, mostly q is still used.
@Immudzen
Copy link
Contributor

Where is this nomenclature used? The CADET documentation in the repository looks like it uses q and not cs.

@schmoelder
Copy link
Contributor Author

schmoelder commented Mar 10, 2020 •
edited

Actually, in the latest TeX document, is already used.

@lieres
Copy link
Member

lieres commented Dec 2, 2020 •
edited

Let's wait with this until a few papers with the new nomenclature are out.

@schmoelder schmoelder added the good first issue Good starting point for newcomers, easy to fix label Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good starting point for newcomers, easy to fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Immudzen @lieres @schmoelder