Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Mixer/Splitter unit operation #40

Open
schmoelder opened this issue Mar 16, 2020 · 1 comment
Open

Implement Mixer/Splitter unit operation #40

schmoelder opened this issue Mar 16, 2020 · 1 comment
Labels
enhancement good first issue Good starting point for newcomers, easy to fix UnitOperation

Comments

@schmoelder
Copy link
Contributor

schmoelder commented Mar 16, 2020

In CADET-Process, flow rates are only specified for Sources and CSTRs. The value of the flow rate for other units is automatically calculated using output state variables that specify the distribution of flow to units following downstream (basically acting as a valve).

For the setup of more complex systems of unit operations, especially those with internal recycles (e.g. SMB), a unit without an actual model would be helpful which just mixes the inputs and distributes the output streams. This could be achieved by setting a CSTR's volume to zero, however, this currently raises a timeout error.

If this is not consistent with the design philosophy of CSTRs, it would also be possible to create a new unit operation (e.g. a Mixer/Splitter/Valve unit).

@sleweke sleweke added enhancement good first issue Good starting point for newcomers, easy to fix and removed bug labels Mar 20, 2020
@sleweke
Copy link
Member

sleweke commented Mar 20, 2020

The CSTR has problems with vanishing volume. It should be able to work with V=0 for some singular time points, but not for whole time intervals.

However, I see your point and there's nothing against it. We can simply add a unit operation for this purpose. It can be based on the Outlet unit operation, which only needs an actual outlet.

We should choose the name carefully. though. A physical valve has dead volume, which may be better modeled by a CSTR. Mixer or Splitter seem better suited.

@schmoelder schmoelder linked a pull request May 10, 2021 that will close this issue
@schmoelder schmoelder changed the title Enable CSTR with zero volume Implement Mixer/Splitter unit operation May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue Good starting point for newcomers, easy to fix UnitOperation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants