Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input pools can not be named like a flux #16

Closed
mbeyss opened this issue Feb 8, 2022 · 1 comment
Closed

Input pools can not be named like a flux #16

mbeyss opened this issue Feb 8, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@mbeyss
Copy link
Contributor

mbeyss commented Feb 8, 2022 •
edited

Otherwise an error is raised

FluxML parsing error: input pool "XXX" specified in equality constraint

or

FluxML parsing error: input pool "XXX" specified in inequality constraint

This originates in fluxml/FluxMLInput.cc, where all equality/inequality constraints are checked for input pool names. It should only be equality constraints for pools.

I would argue, that it is bad practice to have fluxes and pools of the same name, nonetheless this should be fixed.

also: In the error the actual constraint should be printed
@mbeyss mbeyss added the bug Something isn't working label Feb 8, 2022
mbeyss pushed a commit that referenced this issue Feb 9, 2022
fix constraints on input pools
54c7809 
Input pools are not allowed to be constrained (equality or inequality)
The name of input pools was checked against all constraints, erroneously claiming
that pool was constrained if a flux of the same name was constrained.
We now check if the constraint actually applies to a pool

refs #16
@mbeyss
Copy link
Contributor Author

mbeyss commented Feb 9, 2022

fixed

@mbeyss mbeyss closed this as completed Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mbeyss