Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a way to disable viewport-based typography in version 3 ($ms-fluid: false) #155

Open
DamianPereira opened this issue Jun 24, 2018 · 1 comment

Comments

@DamianPereira
Copy link

This is a request for the return of an old feature, in version 2 you could use $ms-fluid: false to disable viewport-based typography. I'd like to retain multiple ratios for each breakpoint, without the resizing between.

This achieves the desired result, but it implies lots of repetition:

$small: 30rem;
$large: 90rem;

$modularscale: (
  base: 1rem,
  small: (
    ratio: 1.2
  ),
  large: (
    ratio: 2
  )
);

h1 {
  font-size: ms(3, $thread: small);
  @media all and (min-width: $large) {
    font-size: ms(3, $thread: large);
  }
}

Maybe if the $ms-fluid can't be re-implemented I can make a new ms-respond-stepped() mixin that implements the above. Should I implement it for myself? Is it some feature you'd like to implement (I can do it and do a PR too if you'd like).

@scottkellum
Copy link
Member

Thanks @DamianPereira I think this is a good addition and glad you found this feature useful. I expected people would switch to the workaround you posted but I’ll look into bringing back $ms-fluid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants