Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of ms-round-px causes build failure #160

Closed
eburton opened this issue Oct 1, 2018 · 7 comments
Closed

Removal of ms-round-px causes build failure #160

eburton opened this issue Oct 1, 2018 · 7 comments

Comments

@eburton
Copy link

eburton commented Oct 1, 2018

Most recent release removed the ms-round-px function, but there is still a ref to the function here:

@return ms-round-px(ms-pow($ratio, $v) * $base);

@scottkellum
Copy link
Member

Oof I really bungled this release. Thank you for the issue and I will fix as soon as I get home

@scottkellum
Copy link
Member

@eburton Can you check again and see that your issue is fixed with whatever package manager or process for updating modular scale you use?

Thanks!

@eburton
Copy link
Author

eburton commented Oct 2, 2018

@scottkellum Looks good! Package manager is still picking up the old version, but I grabbed the latest commit and ran a test and it's not longer grumbling on SASS compilation.

Thanks for the quick response!

@scottkellum
Copy link
Member

@eburton what install method/package manager do you use so that I can investigate?

Thanks! Glad it’s working better

@eburton
Copy link
Author

eburton commented Oct 3, 2018

@scottkellum just bower that seems to be misbehaving :)

bower modularscale-sass#3.x.x mismatch Version declared in the json (v3.0.7) is different than the resolved one (3.0.8)

@scottkellum
Copy link
Member

Thanks I’m going to leave this open until I can test and ensure Bower is behaving and I’ve done things right on my end

@scottkellum
Copy link
Member

@eburton I drafted a new release, let me know if that fixed your issue. Thanks for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants