Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is @modular-scale-classes included? #99

Closed
fchristant opened this issue May 27, 2015 · 3 comments
Closed

Is @modular-scale-classes included? #99

fchristant opened this issue May 27, 2015 · 3 comments

Comments

@fchristant
Copy link

This article about modular scale....

http://thesassway.com/projects/modular-scale

...mentions a mixin @modular-scale-classes which supposedly generates classes. I have a working modular scale setup but it keeps telling me this mixin is undefined. I was wondering whether that is by design or whether I should look for issues in my setup specifically?

Whilst asking this question, I am hoping I can ask one more. Modular scale seems very useful for calculating values based on a ratio, yet I wonder how/if it can help to establish vertical rhythm, where not just the font-size needs to be in ratio, but also it's line-height and or padding. Any best practices for such advanced usage?

@scottkellum
Copy link
Member

@fchristant Hey, this is a really old article and feature and it has been depreciated. I recommend going to modularscale.com if you want to find a list of values or write your own loop if you need to write classes with modular scales.

I’m among the mindset that attempting vertical rhythm is the road to madness, but working with the golden ratio and ems things will tend to fall into place due to properties of the golden ratio and how values relate to other values on the scale.

@fchristant
Copy link
Author

@scottkellum Thanks, eventually I did write my own loop. It generates 10 precalculated classes on the golden ratio scale for font-sizes and bottom margins. I apply them in the markup based on gut feeling. I totally agree that vertical rhythm on the web just cannot be done, except for very trivial websites.

@mashcode
Copy link

mashcode commented Jun 1, 2015

The tyranny of the pixel. Early on it was vellum. Aesthetic choices are always normalizing.

  • I concur on v-rhythm

Marc

On Jun 1, 2015, at 5:18 PM, Scott Kellum notifications@github.com wrote:

@fchristant Hey, this is a really old article and feature and it has been depreciated. I recommend going to modularscale.com if you want to find a list of values or write your own loop if you need to write classes with modular scales.

I’m among the mindset that attempting vertical rhythm is the road to madness, but working with the golden ratio and ems things will tend to fall into place due to properties of the golden ratio and how values relate to other values on the scale.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants