Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@module-federation v2 runtime plugin - beforePreloadRemote args wrongly typed #2567

Open
5 tasks done
Keitar6 opened this issue Jun 3, 2024 · 5 comments
Open
5 tasks done

Comments

@Keitar6
Copy link

Keitar6 commented Jun 3, 2024

Describe the bug

It seems that options should have entry property as well

2024-06-03 12_37_49-Greenshot image editor

And here is what does this property contain:

image

Reproduction

https://github.com/Keitar6/reproMF-chunks

Used Package Manager

npm

System Info

-

Validations

@ScriptedAlchemy
Copy link
Member

I patched a few of these already but will double check.

If you want to submit a PR. You Can you look in core.ts and will see all the hooks

@Keitar6
Copy link
Author

Keitar6 commented Jun 3, 2024

Okay, it would make more sense to just submit a PR for this, you are right. Thank you

@ScriptedAlchemy
Copy link
Member

I'm not the strongest TS dev lol. So you'll probably do it better than I 😂

@ScriptedAlchemy
Copy link
Member

@Keitar6 are you able to open a pr?

@Keitar6
Copy link
Author

Keitar6 commented Jun 13, 2024

Yeah, sure, will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants