Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svg is not resizing to valid viewport #4

Closed
ghost opened this issue Jul 23, 2020 · 3 comments
Closed

Svg is not resizing to valid viewport #4

ghost opened this issue Jul 23, 2020 · 3 comments
Assignees
Labels
🥇 good first issue Good for newcomers

Comments

@ghost
Copy link

ghost commented Jul 23, 2020

List of svg files:

svg_files.zip
Files are opened via double click at windows explorer

Actual result:

Opened svg file size in auto mode is not resizing to valid viewport
Also the "svg options" button is useless in my opinion.

actual_01

Expected result 1

expected_01

Expected result 2

The alternative expected result for "auto" size mode

expected_02

@Beelink Beelink self-assigned this Jul 24, 2020
@Beelink
Copy link
Member

Beelink commented Jul 24, 2020

Do you mean that in auto mode, the image should be resized to fit the window size? (Expected result 2)

Also why the bottom panel is empty? Long file path?

@Beelink Beelink added the 🥇 good first issue Good for newcomers label Jul 24, 2020
@ghost
Copy link
Author

ghost commented Jul 24, 2020

  1. i think for svg icons the 100% option as default be better. I prefer expected 1 result.
  2. i dont view to the bottom panel, it is another bug may be
  3. while i am navigating between icons - the size option always resetted. I think this is a bug too.

@Beelink
Copy link
Member

Beelink commented Jul 25, 2020

Now if image size is smaller than window size -> image will be opened in original size.
You can test it out here:
https://github.com/ModuleArt/quick-picture-viewer/tree/master/quick-picture-viewer/bin/Debug

@Beelink Beelink closed this as completed Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥇 good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant