Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

754: Resolve TS issue on VariantProps #764

Conversation

LucasUnplugged
Copy link
Contributor

@LucasUnplugged LucasUnplugged commented Sep 7, 2021

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 7, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9596d55:

Sandbox Source
Stitches CI: CRA Configuration
Stitches CI: Next.js Configuration

@jonathantneal
Copy link
Contributor

Hey @LucasUnplugged, would your issue also be resolved with #757 (submitted a few days ago)?

@LucasUnplugged
Copy link
Contributor Author

Hey @LucasUnplugged, would your issue also be resolved with #757 (submitted a few days ago)?

We're definitely addressing the same issue. However, I generally try to avoid using the any type if at all possible, so even though this fix is a bit longer, I think it offers stronger typing.

But that's my 2 cents; I'll be happy to have it fixed either way 🙂

@peduarte
Copy link
Contributor

peduarte commented Sep 8, 2021

Luke tried it here and had no luck: #754 (comment)

@LucasUnplugged
Copy link
Contributor Author

Luke tried it here and had no luck: #754 (comment)

Those errors he's seeing are not related — none of them mention the types defined in the file I changed.

In any case, looks like the team chose the other option to solve this issue (using the any), which at least unblocks people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants