Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SolidJS package #819

Closed
wants to merge 2 commits into from
Closed

SolidJS package #819

wants to merge 2 commits into from

Conversation

thdxr
Copy link

@thdxr thdxr commented Sep 30, 2021

This closes #818

This package package is 98% copy paste from @stitches/react with some typing changes + a styled.js implementation. I'm fairly certain we could share types better between these two packages but not sure if that needs to be done right away.

This PR isn't ready to merge yet, I need to update tests for solid but wanted to get the conversation going to see if I should press forward.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f7c35d6:

Sandbox Source
Stitches CI: CRA Configuration
Stitches CI: Next.js Configuration

@jonathantneal
Copy link
Contributor

That was fast. I appreciate you explaining how you put this together.

We’re resolving an issue that will affect a lot of files. Mind if we sit on it until that goes thru? Until that resolution is in, we wouldn’t be ready to consider supporting it.

@thdxr
Copy link
Author

thdxr commented Oct 1, 2021

Sounds good! Is there something I can watch to see when that's done? No worries if not

@thdxr
Copy link
Author

thdxr commented Nov 5, 2021

Hey wanted to follow up here to see if that change went through?

@mzaien
Copy link

mzaien commented Nov 18, 2021

🤯❤️ awesome job

@ch99q
Copy link

ch99q commented Dec 21, 2021

Is there any update on this?

@fabien-ml
Copy link

Hi there, any update on an official solidjs support ?

@thdxr
Copy link
Author

thdxr commented Jan 18, 2022

I published this as solid-stiches in NPM for now

@electroheadfx
Copy link

any news about the solid-stiches repo, I dont find any url to access?

@thdxr
Copy link
Author

thdxr commented Feb 7, 2022

I didn't push to github just to NPM

@electroheadfx
Copy link

hey bro, any NPM url?

@LucasUnplugged
Copy link
Contributor

I didn't push to github just to NPM

Do you mean the opposite of what you said here? I guess you could publish to NPM without committing your code, but that sounds so weird to me 😅

I'm used to seeing the opposite scenario.

@electroheadfx
Copy link

Iam in trouble, if the package is not public sorry.

@thdxr
Copy link
Author

thdxr commented Feb 7, 2022

Iam in trouble, if the package is not public sorry.

https://www.npmjs.com/package/solid-stitches

@ch99q
Copy link

ch99q commented Mar 23, 2022

@hadihallak, Is there any reason this hasn't gotten any attention? The SolidJS is just using the package @thdxr has release, but why not just merge it?

@thdxr
Copy link
Author

thdxr commented Mar 23, 2022

From what I understand the project is going through a major overhaul to be more friendly to static extraction (React 18 requirement)

@jakst
Copy link

jakst commented Mar 23, 2022

From what I understand the project is going through a major overhaul to be more friendly to static extraction (React 18 requirement)

I can't see any activity in this repo for a month, and haven't seen any communication about it either. Where did you hear about this?

@hadihallak
Copy link
Member

Hey @thdxr 👋 Thanks for working on this PR.
We don't currently have plans to officially offer a SolidJS package.
However, We'd be very happy to accept a PR that adds your fork to the list of community packages

@hadihallak hadihallak closed this Jun 6, 2022
@thefrana
Copy link

So after an almost year from original PR, there is no tendency to make it core plugin and community plugin is not listed among others. It is sad to see it like this. There are certainly people that would appreciate at least a mention of the Solid community plugin in the docs.

BTW, thanks everyone for their hard work! ❤️🙏

@thdxr
Copy link
Author

thdxr commented Aug 15, 2022

I've moved on to this: https://github.com/mokshit06/macaron/

@thefrana
Copy link

I've moved on to this: https://github.com/mokshit06/macaron/

Thanks. Looks interesting! Does it work without Vite to be used with NextJS for example?

@LucasUnplugged
Copy link
Contributor

Thanks. Looks interesting! Does it work without Vite to be used with NextJS for example?

It sounds like it uses vanilla-extract under the hood, so it should: https://vanilla-extract.style/documentation/integrations/next/

I had originally decided to move to vanilla-extract as well, but ended up using it only a bit under the hood (to statically generate my CSS), while creating a utility-first-centric system, with custom hashes (only 2 characters long).

But depending on your use case, vanilla-extract is really powerful and really amazing.

@Mokshit06
Copy link

Macaron uses vanilla-extract under the hood for evaluating files, but the build mechanism is completely custom to Macaron, so no it doesn't work with nextjs as of now since it doesn't have a webpack plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SolidJS Support