Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

749: Fixed polymorphic variants type issue #900

Conversation

LucasUnplugged
Copy link
Contributor

NOTE: PR #893 should be merged before this one; if that gets rejected, I can redo this one in a fresh branch*.

Tiny PR to address #749; I'm not sure if the typing is quite right, but based on what I'm seeing in the code, it should be. I've manually tested it where I'm seeing the issue, in my local development, and this resolved it, with no adverse side-effects (that I have seen).


* — I did this for my own convenience, to be able to create a build that has both of these fixes, which are disrupting my TS workflow. As long as #893 gets merged first, this should have no impact on the final result.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 15, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 73646c6:

Sandbox Source
Stitches CI: CRA Configuration
Stitches CI: Next.js Configuration

@LucasUnplugged
Copy link
Contributor Author

Not sure why this isn't picking up that the base branch changed, @hadihallak 🙈

Let me know if you'd rather a do a fresh rebase off canary, to only show this actual change.

@csantos-nydig
Copy link

#893 is merged, could this one be merged now? Thanks

@hadihallak hadihallak requested review from hadihallak and removed request for peduarte February 9, 2022 18:01
@hadihallak
Copy link
Member

Hey @LucasUnplugged Thanks for your effort working on this PR. I did some tests and found some cases where the behaviour of the polymorphic as changed so I dug deeper and was able to solve the issue from the area it originated from in #954

Thanks again for your effort and for helping me fix this issue 🙏

Closing in favor of #954

@hadihallak hadihallak closed this Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants