Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SemVer semantic: 7.0.0-rc1 > 6 #161

Open
maowtm opened this issue Mar 5, 2022 · 2 comments
Open

SemVer semantic: 7.0.0-rc1 > 6 #161

maowtm opened this issue Mar 5, 2022 · 2 comments
Assignees
@Foalfloater66

Comments

@maowtm
Copy link
Collaborator

maowtm commented Mar 5, 2022

Currently semver_geq("7.0.0", "6") is true but semver_geq("7.0.0-rc1", "6") is false (due to the semver crate always returning false when comparing pre-release with non-pre-releases). Need fix.
@maowtm maowtm self-assigned this Mar 5, 2022
@maowtm
Copy link
Collaborator Author

maowtm commented Mar 5, 2022

This may actually require either finding another semver crate or writing our own semver implementation... So before we move on @mechtaev can we discuss the exact semantic we want for semver_*...?

@mechtaev
Copy link
Collaborator

mechtaev commented Mar 5, 2022

The official website has a specification: https://semver.org/. I have not seen anything there that forbids comparing pre-release with non-pre-releases, so it seems like a bug to me.

@Foalfloater66 Foalfloater66 self-assigned this Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Foalfloater66 Foalfloater66

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mechtaev @maowtm @Foalfloater66