Skip to content
This repository has been archived by the owner on Mar 8, 2021. It is now read-only.

Missing "Mediabank" for images and files #291

Closed
fourroses666 opened this issue Jul 2, 2014 · 53 comments
Closed

Missing "Mediabank" for images and files #291

fourroses666 opened this issue Jul 2, 2014 · 53 comments

Comments

@fourroses666
Copy link
Contributor

This idea would be that difficult would it?
Add a TAB / Nav button for media and load KCFinder into the frame!

See example here:
media

I don't think I would be the only one who would use it.

@fourroses666
Copy link
Contributor Author

Also the kcfinder can use a restyle,
use the same folder/container images as the manager (theme), font-sizes, colors etc.
maybe we can add a css file in the /manager/media/styles/theme folder and overwrite some styles?

@Pathologic
Copy link
Contributor

And what's the use of loading KCFinder in dedicated page? File Management replacement?
KCFinder supports theming, though oxygen theme is hard-coded in config.php. It's easy to add theme switching, but somebody has to make theme in MODX style ;)

@fourroses666
Copy link
Contributor Author

No not really a replacement, just quicker access when for example you want to mass upload images with one click on the navbutton, or check what images are on the server. I just think it is more logicall. (Not only images but also the files.)

I can do the css/theming. (based on MODxRE)
(It should be in the theme folder)

@mrhaw
Copy link
Contributor

mrhaw commented Jul 3, 2014

  1. Create a module "Photo Galleries"
  2. header("Location: http://YOURSITE.COM/manager/media/browser/mcpuk/browse.php?&type=images");

@fourroses666
Copy link
Contributor Author

That could be a solution, good thinking Haw, didn't thought about having a module for that.
(rather have a "root" navbutton thow)

@fourroses666
Copy link
Contributor Author

header("Location: /manager/media/browser/mcpuk/browse.php?&type=images"); also works!

maybe the Evo team can decide if they would like to have this default for 1.0.15. (Media button next to Modules?) I really don't know what others think of it, I like it.. not that I use this all the time but it can be very handy and logical for editors/clients..

@mrhaw
Copy link
Contributor

mrhaw commented Jul 3, 2014

@Pathologic
Copy link
Contributor

@fourroses666
To start theme development create a copy of /manager/media/browser/mcpuk/themes/oxygen folder and rename it, then change theme name in /manager/media/browser/mcpuk/config.php. I'll make needed changes when theme is ready.

@mrhaw
And one more https://github.com/Pathologic/Watermarker (; You need to take KCFinder from this branch https://github.com/dmi3yy/modx.evo.custom/tree/develop (and run "INSERT INTO modx_system_eventnames VALUES (NULL, 'OnFileBrowserUpload', '1', 'File Browser Events')") to make a try for this plugin.

@mrhaw
Copy link
Contributor

mrhaw commented Jul 3, 2014

@Pathologic 👍 Very nice!

@janniconl
Copy link

+1 for the idea! Not very good in pulling/pushing but I can help with the css/styling if needed

@fourroses666
Copy link
Contributor Author

Would like to hear something from Jako/Dimmy/Yama about this idea.
I like it in the manager (Media, with subnav: Images - Files) and rather not in a Module.

@Pathologic
Wouldn't it be better if the manager looks at the CSS file in the theme folder:
/manager/style/theme/style.css ? Or just a pulldown in Config > Interface > TinyMCE settings ?

@janniconl
Maybe you can do some KCFinder réstyling for MODxRE?
/manager/media/browser/mcpuk/themes/oxygen/style.css
I'm not able to do it in a "short" time.
Did a pull request once and think I know how to do it again.

Do we need to style this file also? (first popup when clicking on 'Insert image icon')
/assets/plugins/tinymce/jscripts/tiny_mce/themes/advanced/skins/default/dialog.css

I'm not sure what the future brings, will TinyMce be updated to 4.0 soon?
Then we might do some work for nothing..
https://github.com/yama/tinymce4-for-modx-evo

@Pathologic
Copy link
Contributor

@fourroses666
I think about moving KCFinder theme to /manager/style/theme/kcfinder. Theme selector will switch both manager and KCFinder theme. But there's no sense to do that now because of nothing to switch (:

@mrhaw
Copy link
Contributor

mrhaw commented Jul 3, 2014

@fourroses666 I vote to make this module part of EVO by an install script:

photomgr.tpl >> install/assets/modules/

//<?php
/**

header("Location: /manager/media/browser/mcpuk/browse.php?&type=images");

@janniconl
Copy link

@fourroses666 I'll see what I can do this weekend!

@fourroses666
Copy link
Contributor Author

@Pathologic yea, that sounds good to me!
@mrhaw is it possible when installing the module, navigationbutton 'Media' shows up like on my screendump?
@janniconl 👍

@mrhaw
Copy link
Contributor

mrhaw commented Jul 6, 2014

@fourroses666 Just name the module that!? ....The one down side with adding this module is that it will break countless of websites!! ---> Clients will start cleaning up their folders, delete and rename while NOT realizing what pictures are in use or being called on the website... :P

@fourroses666
Copy link
Contributor Author

yea I know we can name it that but I don't want it to be IN the Modules tab :(

Hmm, we can put a textmessage above it:
Be aware when you delete images or files from the server some pages with lniked images or files can be broken. ( or in better english :P )

@mrhaw
Copy link
Contributor

mrhaw commented Jul 6, 2014

Why not promote a link (or button) on manager home?

This is how I set up every web site: http://i2.minus.com/jCUfO0SACNqD0.png

Howto: http://forums.modx.com/thread/74864/create-a-new-blog-post-link-in-welcome-html#dis-post-415197

@fourroses666
Copy link
Contributor Author

+1
I think that would be the best place to put it (two icons: images/files)!
Would love to have it installable by the (new) PackageManager.

this
files
images
files

@fourroses666
Copy link
Contributor Author

How do we go from here, I like it like the idea above and think we should go on with this.
Do we need to make a module to let the two icons link to the right page or shall we make this default?
It can be done with minor CMS changes.

@mrhaw
Copy link
Contributor

mrhaw commented Jul 7, 2014

My vote is NOT making it part of the core. // MODX is no longer Creative Freedom if everything gets built in. As an extra we can modify and customize. When it's in the core I have to hack MODX to get it my way.

@fourroses666
Copy link
Contributor Author

it is already in modx, all we do is add a link to it on the dashboard.
at least we can add it with a module. I will have a look at the custom building.
must be doable;
http://forums.modx.com/thread/90161/modxflat---evolution-manager-theme-with-customizable-dashboard-shortcuts-and-color-skins

@nick0
Copy link

nick0 commented Jul 8, 2014

This sounds like a nice idea, in bringing Evo more in line with WordPress grouping images and files together in the one media section but I don't think it is necessary.

Evo separates images and files in the assets folder so this is quite a change. That currently works fine if you ask me.

It sounds like this concept has the potential to break sites on update, it should not be part of the core. I wouldn't use it.

Think about a 1,000 page website. That's a lot of image / file links to update. And then repeat for every site you need to update. No thanks.

You could have Elements > Manage Images instead and keep it separate.

@fourroses666
Copy link
Contributor Author

It don't change the way it already works, it is just to reach/look at the images faster, the only way to check your uploaded images now is to use TinyMce images icon.

@nick0
Copy link

nick0 commented Jul 8, 2014

Ok great - I got scared by mrhaw's comments "The one down side with adding this module is that it will break countless of websites!!". Sounds better already

@fourroses666
Copy link
Contributor Author

I really wouldn't know how it would break them

@mrhaw
Copy link
Contributor

mrhaw commented Jul 8, 2014

As I mentioned above, I make use of the thumbnails KCFinder automatically generates and use image TV's for photo galleries. When my clients select images using the KCFinder Browser they learn the connection and relationship the images has with the resource and links. = Excellent UI/UX.

Getting straight to the KCFinder Browser is great for skilled manager users who knows NOT TO RENAME AND DELETE. For all other users those 2 options need to be removed when right-clicking.

This is HOWEVER doable. We have to add an alternative browser using different javascript...
https://github.com/modxcms/evolution/blob/bugfix/manager/media/browser/mcpuk/js/browser/files.js#L409

@Nicola1971
Copy link
Contributor

fourroses666 try to use this plugin:
https://github.com/Nicola1971/OnManagerWelcomeCustom-plugin
(the latest version includes the shortcut to the photo gallery)

with this theme (for a classic Evo style):
https://github.com/Nicola1971/MODxRE-D

@Nicola1971
Copy link
Contributor

My opinion is it's better to simplify the customization of the default welcomehome that add additional links for everyone.

@Nicola1971
Copy link
Contributor

Got another solution: Open the gallery module in a popup window, so you can open it at anytime and from anywhere :)
https://github.com/Nicola1971/TreeGalleryButton-Plugin
pic

popup

@janniconl
Copy link

Thx Nicola1971! Works like a charm (so does your TreeElementsButton)

@fourroses666
Copy link
Contributor Author

Thanks Nicola

I still think it should be default thow as I suggested on my first post, In my eyes this is basic stuff in a CMS

Wordpress:
640px-managefiles

@Nicola1971
Copy link
Contributor

as a graphic designer and developer, I really like it, but only one customer asked me this kind of module and it was a tattoo studio (with a lot of photos, of course).
For me: The solution to many of these requests is to add Package Manger and Store modules.
In this way, like in revo, you can immediately install all your favourite customizations and extras.

@Nicola1971
Copy link
Contributor

Yet another solution :)
I've added 3 new system events in the menu.php.
https://github.com/Nicola1971/m-evolution

Using OnManagerTopFrameMenu you can create small plugins to add custom items in Evo Menu:
addmenu

@fourroses666
Copy link
Contributor Author

Thanks! Thats exactly like my first example image 👍
Can't find the OnManagerTopFrameMenu in 1.0.14, hopefully it will be in next Evo version.

@Dmi3yy
Copy link
Collaborator

Dmi3yy commented Sep 25, 2014

see event and refactor top menu:
https://github.com/dmi3yy/modx.evo.custom/blob/develop/manager/frames/mainmenu.php
https://github.com/dmi3yy/modx.evo.custom/blob/develop/manager/frames/mainmenu.php#L73

i thins this solution will be more right
You can not only add:)

and have one more thing

move folder frames to media/style now can do anyting in style) without change CORE

@janniconl
Copy link

Nice addition Nicola! Would be nice indeed if this could be added to the normal Modx Evo.

@Nicola1971
Copy link
Contributor

Mine is a very immediate solution, but functional.
Move all frames in the template would be really great, I agree with Dmi3yy.

I would also add an event in the head section of menu.php OnManagerTopFrameHeaderHTMLBlock to load styles and js in the top frame.
In this way, users can customize Manager Themes without writing code or knowing the evo theme structure.
See my Manager Styler Beta:
https://github.com/Nicola1971/ManagerStyler

@Dmi3yy
Copy link
Collaborator

Dmi3yy commented Sep 25, 2014

OnManagerTopFrameHeaderHTMLBlock - its already done )

https://github.com/dmi3yy/modx.evo.custom/blob/develop/manager/frames/1.php

and replace FRAMESET to iFrame ))
see my theme:
http://monosnap.com/image/BVCt3fCmBJ5RKwaGY7yPsrIcPZXe5b

now do popup plugins with hotkeys)
http://monosnap.com/image/voLL0orKgZxUoas2QSj45OXh8LhfsP
https://www.youtube.com/watch?v=_5nLhIixbX4

and some new feautes in develop
https://www.youtube.com/watch?v=03DPTt_Znx4

@Nicola1971
Copy link
Contributor

dmi3yy you make me feel really happy!! - it's really awesome!!!
but I fear that we will not see very soon these additions default in Evolution
Can I help you in any way?!?!

@Dmi3yy
Copy link
Collaborator

Dmi3yy commented Sep 25, 2014

Hopefully next week I'll have time, I will describe the changes At last there about official version.

then discuss that transfer to the official version and what is not.

@Nicola1971
Copy link
Contributor

I could not wait. Just downloaded the develop branch and installed in my local wamp :)

@Dmi3yy
Copy link
Collaborator

Dmi3yy commented Sep 25, 2014

wait one hour, do update from my master branch andd off bugfix

@Dmi3yy
Copy link
Collaborator

Dmi3yy commented Sep 25, 2014

done, love merge, passed without conflicts:)
now need only update readme,

@Nicola1971
Copy link
Contributor

Honestly, I did not understand the usefulness of OnManagerPreFrameLoader. can you explain?
OnManagerPreFrameLoader is the "Container" frame (1.php) and due to the frame structure can not affect the internal frames (top, left, main)
For this reason, I added OnManagerTopFrameHeaderHTMLBlock into the top (menu) frame.
https://github.com/Nicola1971/m-evolution/blob/bugfix/manager/frames/menu.php#L199

@Dmi3yy
Copy link
Collaborator

Dmi3yy commented Sep 25, 2014

No more frame, FREMESET, then we can work with Body
https://github.com/dmi3yy/modx.evo.custom/blob/develop/manager/frames/1.php#L33-L46

@Nicola1971
Copy link
Contributor

in your branch OnManagerPreFrameLoader certainly makes sense :)
I never understood how to use it in the current modx 1.0.14. Only a step for future changes?

@Dmi3yy
Copy link
Collaborator

Dmi3yy commented Sep 25, 2014

yes Only a step for future changes

@Nicola1971
Copy link
Contributor

tested it's really awesome, but still cant find a way to load styles or js in the top "iframe".
screen

However, if your evo-custom mods will not be merged shortly with modx evolution, in the meantime (1.0.15) we can add "OnManagerTopFrameHeaderHTMLBlock " to allow add styles and js in the top frame..

and add your "OnManagerMenuPreRender" in the same way and place of my "OnManagerTopFrameMenu " to allow add new menu items like image gallery in the next release.
https://github.com/Nicola1971/m-evolution/blob/bugfix/manager/frames/menu.php#L398

With this event it's really simple create a plugin to add a new menu in the current (1.014) menu frame
https://github.com/Nicola1971/m-evolution/blob/bugfix/install/assets/plugins/AddNavMenu.tpl

Two small additions of code that provide a big upgrade for manager customization and "two steps for future changes" :)

@Dmi3yy
Copy link
Collaborator

Dmi3yy commented Sep 26, 2014

I think we can add one more event 'OnManagerTopFrameHeaderHTMLBlock'

sample plugin for change topmenu:
$e = &$modx->Event;
switch($e->name){
case 'OnManagerMenuPrerender':
unset($menu['reports']);
$menu['orders'] = array('orders','main','Заказы','#orders','Заказы','new NavToggle(this); return false;','','',0,60, '');
$menu['neworders'] = array('neworders','orders','Новые заказы','index.php?a=112&id=4','Новые заказы','this.blur();','','main',0,60, '');
$e->output(serialize($menu));
break;
}

i think need realize version 1.1 but for start this need do mysql -> mysqli

@Dmi3yy
Copy link
Collaborator

Dmi3yy commented Sep 26, 2014

for change Theme will be intresting
http://modx.im/blog/develop/1697.html

Nicola what your skype? add in chat its easy and faster for talking

@Dmi3yy
Copy link
Collaborator

Dmi3yy commented Sep 26, 2014

What about this issues topiс?
i think need do this with plugin no core

@fourroses666
Copy link
Contributor Author

If you really don't like it to be core then plugin is oké with me too. 📦

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants