Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment color in Zen theme is very low contrast #20

Closed
kkga opened this issue Feb 26, 2023 · 1 comment · Fixed by #21
Closed

Comment color in Zen theme is very low contrast #20

kkga opened this issue Feb 26, 2023 · 1 comment · Fixed by #21

Comments

@kkga
Copy link
Contributor

kkga commented Feb 26, 2023

It feels that the current comment color in Black Zen is unnecessarily dark, compared to the (non-Zen) Black theme:

"foreground": "#ffffff2f"

Black Zen:
image

Black:
image

Both Black and Dark themes use a different shade of gray, so maybe it's worth using the same for Zen?

"foreground": "#ffffff4f"

"foreground": "#ffffff4f"

@ddiu8081
Copy link
Member

Yes, I think you are right, the comment color is indeed so dark. Thanks!

There's a bit of work to do next before going live. The color of keywords(#747476) is needed to be adjusted, otherwise they would be similar to the comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants