Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch-remote-play-host deleted by windows defender - fix documentation #19

Closed
lapp0 opened this issue Feb 26, 2021 · 7 comments
Closed
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@lapp0
Copy link

lapp0 commented Feb 26, 2021

The current docs don't work because switch-remote-play-host is automatically deleted when extracted, both from 7zip and zip. There is no option in windows defender to allow this program before or after it's run.

To resolve this you must

  • copy the folder over
  • do not view properties, open, or do anything with switch-remote-play-host
  • Open windows defender
  • Virus & threat protection
  • quick scan
  • select the switch-remote-play-host folder
  • there will be a virus detected message: Trojan:Win32/Wacatac.D6!ml,
    • Verify that switch-remote-play doesn't include malware. I have no idea whether it does! Please check for yourself, it is a good security practice. Note, a quick review appears that this often is the result of unsigned binaries. Perhaps a separate issue should be created to sign your releases?
    • you must select "allow on system"
  • if the file was deleted, you must extract once more
  • all set!
@lapp0
Copy link
Author

lapp0 commented Feb 26, 2021

Related to #15 #10

@Moehammered
Copy link
Owner

Thank you for detailing how you managed to get Windows Defender to stop deleting it.

I've found that Windows Defender also has been updated now and can delete files within a 7zip archive. But regardless of this users can always check the Windows Defender history and go through the threats and choose to allow them.

Or users can whitelist a folder but I chose not to show users how to do in the interest of not causing security issues for users.

As for signing, I attempted that in one of the previous releases but it did not stop it from triggering the virus detection. Like I have stated in the documentation, it is due to 2 features of the program:

  • It keeps a broadcast port open for listening
  • It executes ffmpeg via CreateProcess

I don't know a way around this issue yet. Only thing I've seen is to contact the virus scanners and request a whitelist of the program but because I am still working on it and updating it I'd rather not.
That said, this is also why people should only ever download this program from this repository. If some malicious person replaced the ffmpeg.exe file with a virus then it'd be dangerous. Thankfully however the proper ffmpeg program doesn't get detected as a virus. So if it ever does, users can and should go and download the ffmpeg program themselves.

Thank you for providing a breakdown on how you solved the issue. I will update the documentation to include a link to your comment as well as provide a way to safely ensure ffmpeg is safe for users who'd like to take extra precautions.

I will close this issue once the documentation is updated.

Kind Regards.

@lapp0
Copy link
Author

lapp0 commented Feb 26, 2021

@Moehammered
Copy link
Owner

I'm aware of the virustotal results of the executable. The debug version also produces different results.

  • Network adapter functionality
    • It is necessary. Scans broadcast for network discovery of switch. Prints out diagnostic info of network configuration. Accepts connection from the switch in order to stream data.
  • Rich pe linker version
    • I'm unsure of what the exact 'fix' was in that link. Reading through it, the dev made a submission to Microsoft to whitelist the application. Is that what you were referring to?
    • In the case of submitting a whitelist request, I don't plan to do one anytime soon because there are many modifications I'm still in the process of making. I don't want to have to create a whitelist submission for every release. Once the program is in a stable state I will consider it.

The rest are most likely triggering from CreateProcess. You can google other users using the CreateProcess function and having similar issues. I don't have a way around that yet.

@Moehammered
Copy link
Owner

Thanks for digging that up for me. Much appreciated!

Yeah I noticed that the build files in that linked repo started using qmake.exe to perform the builds.
I'll look into link.exe and see if I can remove it from the build process if it's present. I'm just hoping it isn't the actual linker program because then removing it would not be possible.

You've been very helpful. Please no apologies necessary :)

@Moehammered Moehammered self-assigned this Mar 3, 2021
@Moehammered Moehammered added the documentation Improvements or additions to documentation label Mar 3, 2021
@ElBori82
Copy link

Up voted this on virstotal and left a brief description. I also marked it as safe on Hitman Pro. Hope this helps somehow.

@Moehammered Moehammered moved this from Done to Archived(v0.9 or less) in Switch Remote Play - Road to version 1.0 Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Development

No branches or pull requests

3 participants