New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Request] Lyrics: "回访顺带问问歌词的坑（" #4

Closed

Myer921 opened this issue May 24, 2016 · 5 comments

Myer921 commented May 24, 2016

不知道作者大大你何时能把歌词的坑填好（

Collaborator

grzhan commented May 25, 2016 •

edited

之前迟迟不支持歌词的原因是：若要支持歌词，插件标签的形式必须变成拥有闭合标签的形式（形如 <aplayer></aplayer>），这样的话若不使用歌词的时候使用体验似乎不是很好。

不过刚才想了下，可能歌词和插件的标签可以分开做，所以应该很快就能支持歌词。

grzhan changed the title ~~回访顺带问问歌词的坑（~~ [Request] Lyrics: "回访顺带问问歌词的坑（"

Author

Myer921 commented May 26, 2016

好我那等着～

Myer921 closed this as completed

Myer921 reopened this

Author

Myer921 commented May 26, 2016

好像我这边有人把坑填了然后我不能在fork这个项目了
我想提交一个来的= =

Collaborator

grzhan commented May 26, 2016

@Myer921 如果是写dplayer的话其实把代码拿过去然后自己建个独立的项目就好（在Readme通过inspired等说法进行说明）。

如果有dalao已经写好歌词的feature的话可以从这个项目fork出来，然后提交pr，我会merge进去。

这是比较常规也是比较礼貌的做法。

Author

Myer921 commented May 27, 2016

已经提交

Myer921 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment