Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when touching person icon in conversion with automated sender (3.0.0 Preview 8) #869

Closed
TeeTeeHaa opened this issue Feb 7, 2018 · 15 comments
Assignees
Labels

Comments

@TeeTeeHaa
Copy link

TeeTeeHaa commented Feb 7, 2018

When you get a SMS message from an automated sender, for example from a mobile phone carrier or a bank, and open the "conversion" and then touch the round "person" icon left of the received message text, QKSMS crashes.

QKSMS 3.0.0 Preview 8 on Android 8.0.0 with January 2018 security patch level on Nokia phone

Using Simple-Contacts as default contacts app, having the stock Android "Contacts" app from Google disabled

Using stock Android "Phone" app from Google as default dialer (not having found an open source replacement yet...)

@moezbhatti
Copy link
Owner

If you go into the app settings and click Sync messages and try again, does this still happen?

@moezbhatti moezbhatti added the bug label Feb 7, 2018
@moezbhatti moezbhatti self-assigned this Feb 7, 2018
@TeeTeeHaa
Copy link
Author

TeeTeeHaa commented Feb 8, 2018

Yes, it crashed the first time when opening the conversion and after a restart it crashed when touching the "person" icon, just like before.

I installed 'adb' on my PC and created a log file with 'abd logcat'. The (in my eyes) relevant part of that file is
attached here.

Are there any other log file information which might help you?

In addition...

When touching the "person" icon in the main screen of QKSMS crashes it, too.

When touching the "person" icon of a message from a known sender in the main screen of QKSMS simply opens that contact, in my case using Simple-Contacts (mentioned above).

I'm currently unsure whether this is an issue of QKSMS or Simple-Contacts. Nevertheless QKSMS should not crash even if there simply there would be no contacts app installed at all.

@moezbhatti
Copy link
Owner

@TeeTeeHaa can you try this build and let me know if it resolves the crash? You may need to uninstall the current installation of the app

qksms-noAnalytics-debug.apk.zip

@moezbhatti moezbhatti added this to To do in Issue tracker via automation Feb 12, 2018
@moezbhatti moezbhatti moved this from To do to In progress in Issue tracker Feb 12, 2018
@TeeTeeHaa
Copy link
Author

TeeTeeHaa commented Feb 12, 2018

I tried to install the provided APK file but that did not work: "App not installed." it said. Logcat attached.

@TeeTeeHaa
Copy link
Author

TeeTeeHaa commented Feb 12, 2018

I installed the APK file of 3.0.0 Beta 1 instead, that did work. Unfortunately both crashes mentioned above still happen.

@moezbhatti
Copy link
Owner

@TeeTeeHaa can you try this one? qksms-noAnalytics-release.apk.zip

@TeeTeeHaa
Copy link
Author

With this build:

  • Installation works, app starts, app can be set as default app for SMS.
  • Touching person icon left of SMS from automated sender in list of SMS shows message "No apps can perform this action."
  • Touching person icon left of SMS from automated sender in conversation shows the very same message.
  • Touching "Help & feedback" in menu shows the very same message (Chrome and Firefox are installed, Firefox is the default browser).

Wild guess: Trying to create a new contact from an SMS to/from a sender not in the address book where some information in the new contact will be prefilled from the SMS or trying to create a new contact from an SMS without an actual telephone number (automated sender), that does not work. Maybe this it is not (yet) supported by Simple-Contacts or maybe QKSMS does initiate it in a "wrong" way.

Another info: When I touch a person icon in the default dialer app "Phone" (from Google) within the call history for a telephone number being not yet in my contacts, simply nothing happens. I'm not sure whether that is default behavior. Naively I would expect that a new contact will be created, prefilled with some information taken from the call history.

@moezbhatti
Copy link
Owner

So it seems to me like there's something strange going on with how Nokia's version of android is handling defaut apps. I'm using standard intents for sending an email or creating a contact, as I'm assuming the Phone app is as well. Even if Simple Contacts doesn't support it, then the phone's default contacts app should be displayed as an option.

And for clarification, the help & feedback open should open your email client, not your browser.

At this point I'm not exactly sure what a solution could be. I've tried a slightly different method of building the add contact intent. Can you try this build and let me know if anything different happens

qksms-noAnalytics-release.apk.zip

For reference, I've changed the intent uri from Uri.parse("tel: $address") to Uri.fromParts("tel", address, null) as recommended in the ContactsContract.Intents.SHOW_OR_CREATE_CONTACT documentation

@TeeTeeHaa
Copy link
Author

Nokia always says it is using an Android as stock as possible.
The default contacts app won't open because it is disabled on my device.
I do not have an email app installed and the GMail app is disabled on my device.
I'll try your new build later today.

@TeeTeeHaa
Copy link
Author

With that build:

  • Installation works, app starts.
  • Touching person icon left of SMS from automated sender in list of SMS shows message "No apps can perform this action."
  • Touching person icon left of SMS from automated sender in conversation shows the very same message.
  • Touching "Help & feedback" in menu shows the very same message.

So it seems that nothing changed.

I'm not sure whether this is an issue of QKSMS or Simple-Contacts. Maybe Simple-Contacts is simply not providing the correct intend. After your next Beta build, which hopefully contains the changes of "my personal" builds, I might open an issue for Simple-Contacts.

@moezbhatti
Copy link
Owner

Could you see what happens if you temporarily enable your email and contacts apps?

@TeeTeeHaa
Copy link
Author

After enabling "Contacts" and "GMail":

  • Touching person icon left of SMS from automated sender in list of SMS: The first time "Contacts" was opened, second third and other times nothing happened.
  • Touching person icon left of SMS from automated sender in conversation: A message appears "Add 'somename' to contacts? CANCEL OK". Touching OK opens "Contacts" with the title "Add to contact". When Touching "Create Contact" the dialog to create a new contact appears with phone number field prefilled with 'somename' (currently I have only SMS from automated senders or from people being already present in my contacts list; I do not have a normal SMS from somebody not in my contacts list yet)
  • Touching "Help & feedback" in menu: GMail opens.

@moezbhatti
Copy link
Owner

Okay, it sounds like things are working as expected in that case. And it sounds like Simple-Contacts simply hasn't added support yet for adding a contact via intent from other apps

The crash has been resolved (now if there are no supported apps, it will display that instead of crashing), so I'll close the issue. Thanks for all the help in narrowing this down!

Issue tracker automation moved this from In progress to Done Feb 16, 2018
@TeeTeeHaa
Copy link
Author

Does 3.0 Beta 2 include all necessary fixes?

@moezbhatti
Copy link
Owner

@TeeTeeHaa yep, these changes have been incorporated in Beta 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants