Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vizanti via HTTPS #82

Closed
gxomalis opened this issue May 22, 2024 · 1 comment
Closed

vizanti via HTTPS #82

gxomalis opened this issue May 22, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@gxomalis
Copy link

Hey there!

I just converted my web app from http to https, and I was using an iframe to get localhost:5000 to my web app to show vizanti inside a page. After the conversion the iframe did not work as i got a mixed content error, because my web app is https and vizanti is http. So I did my research, worked around vizanti's server files. I managed to make vizanti run on https but I cant figure how to make rosbridge run on https or wss. No matter what I do, its always up on http://localhost:5001/. So my question is, is it possible to make rosbridge also run on https so it communicates with the https vizanti and finally show it on my https web app? If so, can you guide me on how to achieve that?

@gxomalis gxomalis added the bug Something isn't working label May 22, 2024
@MoffKalast
Copy link
Owner

MoffKalast commented May 22, 2024

Afaik if launching rosbridge with ssl set to true and a valid ssl cert is given as the certfile and keyfile then it should just work, something along the lines of this. I think I last tried that sometime on Kinetic though so I'm not sure how well it's supported on Humble or if the param names have changed.

One thing that would definitely need to be edited is changing ws to wss in rosbridge.js so that the client connects to it properly.
If that works, then it should be simple to send it along the other launch params that already need to be set so it doesn't have to be hardcoded, or we could just check if the page is being loaded as https I suppose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants