New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3 support #53
Python 3 support #53
Conversation
There's one failing test, and then I'm ready to merge this, even if Python 3 support is only "experimental" |
Fixes #7 * Try to avoid easy_install - `python-daemon` won't install correctly with easy_install * Remove win32 "support" - it was untested and couldn't be used in production anyway. * Mock chardet rather than the string object * Don't use reserved words * Do binary file reading properly * SMTPD messages are slightly different between Python 2 and 3 * Put test states.db in a folder that gets cleaned between test runs * Depending on what version of Python we're using, `reload` could in one of three places. * Use more modern try: except: syntax that words in both Python 2 and 3 * Print is a function in Python 3
67a3961
to
4855991
Compare
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
==========================================
+ Coverage 93.66% 93.69% +0.03%
==========================================
Files 14 14
Lines 1484 1539 +55
==========================================
+ Hits 1390 1442 +52
- Misses 94 97 +3
Continue to review full report at Codecov.
|
529c620
to
9b51f83
Compare
* stop using type when isinstance will work fine * don't try to import reload from imp on Python 2.7, it's a builtin * codecov doesn't ignore salmon/data as it should
9b51f83
to
b20e429
Compare
Previously this was the case by default in Python 2
Hi! Do you need help to finish this up? |
It needs testing with a proper app before merging. I don't trust the unit tests quite enough to go ahead and merge these changes. |
As I suspected:
|
Conflicts: CHANGELOG.rst salmon/utils.py tests/salmon_tests/message_tests.py tests/salmon_tests/queue_tests.py tests/salmon_tests/server_tests.py
Even in cases where it might not make sense
* Remove references to SCANNER, it doesn't exist anymore * Better coverage of encoding tests * Fix whitespace errors
Fixes #7
production anyway.
reload
could in oneof three places.