Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode support in Firefox extension #30

Closed
vercas opened this issue Mar 27, 2024 · 8 comments
Closed

Dark mode support in Firefox extension #30

vercas opened this issue Mar 27, 2024 · 8 comments
Labels
feature request New feature or request

Comments

@vercas
Copy link

vercas commented Mar 27, 2024

This is what it currently looks like when bookmarking a page:
Screenshot 2024-03-27 at 17 22 09

@MohamedBassem MohamedBassem added bug Something isn't working feature request New feature or request and removed bug Something isn't working labels Mar 27, 2024
@MohamedBassem
Copy link
Collaborator

That looks ugly indeed, will fix it :)

@JFPCreations
Copy link

JFPCreations commented Mar 27, 2024

+1
I was about to post the same but for chrome extension in Brave. ;)
Because of dark theme the popup is looking weird.

brave_hrWgny1hWV
mxEpIQ7DKR

@MohamedBassem
Copy link
Collaborator

MohamedBassem commented Mar 27, 2024

I'm actually, curious, how did you get to have dark mode in the extension popup. It seems that for me, it's always in light mode regardless of what my theme color is :D Are you using any plugin that forces dark mode in websites or something?

EDIT: Oh, nvm. It's in dark mode when the system itself is in dark mode. Managed to repro.

@MohamedBassem
Copy link
Collaborator

Thanks for the report, I think it looks slightly nicer now. Will be available in the next extension release.

Screenshot 2024-03-27 at 5 58 03 PM

@JFPCreations
Copy link

Thank you for this fast work. Did you or can you add a white icon the the dark theme?
image

@MohamedBassem
Copy link
Collaborator

I don't think I can customize the icon based on wether it's light mode or dark mode. I checked and chrome developer's guide suggestion is to add a subtle white glow around the logo to make it visible in dark mode. Let me do that.

@MohamedBassem MohamedBassem reopened this Mar 27, 2024
@vercas
Copy link
Author

vercas commented Mar 27, 2024

This extension switches its toolbar icon in Firefox: https://github.com/Mika-/torrent-control

@JFPCreations
Copy link

I think you have upgraded the extension.

It is viewable now.

image

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants