Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter branch name when notifying on PR commits #169

Open
monitorjbl opened this issue Apr 2, 2016 · 1 comment
Open

Alter branch name when notifying on PR commits #169

monitorjbl opened this issue Apr 2, 2016 · 1 comment

Comments

@monitorjbl
Copy link

The branch name system works great for single repos, but it kind of falls apart when forks are involved. Because the PR commit only uses the branch name from the source repo, a fork can trigger Jenkins jobs that should not be triggered. For example, if the fork uses the branch name master, any jobs that are meant to build merged code will run on the unmerged PR code.

It seems like it would be fairly trivial to fix this by prepending the forked repo name to the branchname, or even simply sticking a pr- in front of the name. That way, Jenkins jobs could be configured to only run on PRs.

@dodok1
Copy link

dodok1 commented Dec 28, 2016

IMO, there is #172 covering this use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants