Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why Redux? (or: Refactor to use Hooks+Context) #53

Open
dotansimha opened this issue Mar 23, 2020 · 2 comments
Open

Why Redux? (or: Refactor to use Hooks+Context) #53

dotansimha opened this issue Mar 23, 2020 · 2 comments

Comments

@dotansimha
Copy link
Contributor

It there a reason to use Redux? It seems like there is a mixup of Redux state, hooks and props passing across this repo. It could be simplified by using hooks for most cases, and use React context to manage state and share it across components.
I know hooks doesn't completely replace Redux and state, but in this case, and in small apps, it could simplify things.

I can help with improving it if the maintainers are ok with it :)

@kaminskypavel
Copy link

suggestion: rename the issue to "refactor to use hooks"
your title opens a discussion we all had many times, "why not mobx" , "why not context"?

IMO this would be a redundant effort.

@dotansimha dotansimha changed the title Why Redux? Why Redux? (or: Why not Hooks+Context) Mar 23, 2020
@dotansimha dotansimha changed the title Why Redux? (or: Why not Hooks+Context) Why Redux? (or: Refactor to use Hooks+Context) Mar 23, 2020
@dotansimha
Copy link
Contributor Author

@kaminskypavel It's always depends on how big you project is and what are the needs of it.
I agree with you in this case, here is should be refactored to use Hooks and Context when possible. The reason I asked "Why Redux?" is because I wanted to understand what were the reasons to choose it - are there any plans to extend the app to do more? or maybe something we don't know about in the roadmap?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants